fix: handle pandas 3.0 default StringDtype#1777
Open
filippsatverily wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@SFJohnson24 another commit from #1745 |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas 3.0 changes the default string dtype from
objecttoStringDtype, which requires these changes:Regex operators:
.map()now returns nullableBooleanDtype, wherepd.NA & Trueraises instead of returningFalse. Adds a_map_regex()helper that normalizes to numpy bool via.fillna(False).astype(bool), used by all prefix/suffix/matches regex operators.Case-insensitive comparisons:
.lower()on a non-string value (e.g.pd.NA) raisesAttributeError. Guards withisinstance(target_val, str)before calling.lower().Empty-column detection in record_count: checks
dtype == "object"to identify string columns, which missesStringDtype. Usespd.api.types.is_string_dtype()instead.Date validation: simplifies the
is_valid_dateguard tonot isinstance(date_string, str), which already handlesNone,pd.NA, and any other non-string type.Tested scenarios: