Add UPLOAD_DOCUMENT to default service perms (#2956)

* Add `UPLOAD_DOCUMENT` to default service perms

* Fix tests

Author: whabanks

app/dao/services_dao.py

@@ -29,6 +29,7 @@
     NHS_ORGANISATION_TYPES,
     NON_CROWN_ORGANISATION_TYPES,
     SMS_TYPE,
+    UPLOAD_DOCUMENT,
     AnnualBilling,
     ApiKey,
     FactBilling,
@@ -61,6 +62,7 @@
     SMS_TYPE,
     EMAIL_TYPE,
     INTERNATIONAL_SMS_TYPE,
+    UPLOAD_DOCUMENT,
 ]
 
 

tests/app/dao/test_services_dao.py

@@ -54,6 +54,7 @@
     KEY_TYPE_TEST,
     LETTER_TYPE,
     SMS_TYPE,
+    UPLOAD_DOCUMENT,
     ApiKey,
     InvitedUser,
     Job,
@@ -646,6 +647,7 @@ def test_create_service_returns_service_with_default_permissions(notify_db_sessi
             SMS_TYPE,
             EMAIL_TYPE,
             INTERNATIONAL_SMS_TYPE,
+            UPLOAD_DOCUMENT,
         ),
     )
 
@@ -658,14 +660,12 @@ def test_create_service_returns_service_with_default_permissions(notify_db_sessi
             (
                 EMAIL_TYPE,
                 INTERNATIONAL_SMS_TYPE,
+                UPLOAD_DOCUMENT,
             ),
         ),
         (
             EMAIL_TYPE,
-            (
-                SMS_TYPE,
-                INTERNATIONAL_SMS_TYPE,
-            ),
+            (SMS_TYPE, INTERNATIONAL_SMS_TYPE, UPLOAD_DOCUMENT),
         ),
     ],
 )
@@ -699,7 +699,7 @@ def test_create_service_by_id_adding_and_removing_letter_returns_service_without
     dao_add_service_permission(service_id=service.id, permission=LETTER_TYPE)
 
     service = dao_fetch_service_by_id(service.id)
-    _assert_service_permissions(service.permissions, (SMS_TYPE, EMAIL_TYPE, INTERNATIONAL_SMS_TYPE, LETTER_TYPE))
+    _assert_service_permissions(service.permissions, (SMS_TYPE, EMAIL_TYPE, INTERNATIONAL_SMS_TYPE, LETTER_TYPE, UPLOAD_DOCUMENT))
 
     dao_remove_service_permission(service_id=service.id, permission=LETTER_TYPE)
     service = dao_fetch_service_by_id(service.id)
@@ -710,6 +710,7 @@ def test_create_service_by_id_adding_and_removing_letter_returns_service_without
             SMS_TYPE,
             EMAIL_TYPE,
             INTERNATIONAL_SMS_TYPE,
+            UPLOAD_DOCUMENT,
         ),
     )
 
@@ -862,6 +863,7 @@ def test_delete_service_and_associated_objects(notify_db_session):
             SMS_TYPE,
             EMAIL_TYPE,
             INTERNATIONAL_SMS_TYPE,
+            UPLOAD_DOCUMENT,
         )
     )
 

tests/app/service/test_rest.py

@@ -33,6 +33,7 @@
     KEY_TYPE_TEST,
     LETTER_TYPE,
     SMS_TYPE,
+    UPLOAD_DOCUMENT,
     EmailBranding,
     InboundNumber,
     Notification,
@@ -295,6 +296,7 @@ def test_get_service_list_has_default_permissions(admin_request, service_factory
                 EMAIL_TYPE,
                 SMS_TYPE,
                 INTERNATIONAL_SMS_TYPE,
+                UPLOAD_DOCUMENT,
             ]
         )
         for json in json_resp["data"]
@@ -309,6 +311,7 @@ def test_get_service_by_id_has_default_service_permissions(admin_request, sample
             EMAIL_TYPE,
             SMS_TYPE,
             INTERNATIONAL_SMS_TYPE,
+            UPLOAD_DOCUMENT,
         ]
     )