Add 2 new indexes to the jobs table (#2552)

created_at and processing_started

Author: smcmurtry

app/models.py

@@ -1517,7 +1517,7 @@ class Job(BaseModel):
     template_version = db.Column(db.Integer, nullable=False)
     created_at = db.Column(
         db.DateTime,
-        index=False,
+        index=True,
         unique=False,
         nullable=False,
         default=datetime.datetime.utcnow,
@@ -1534,7 +1534,7 @@ class Job(BaseModel):
     notifications_delivered = db.Column(db.Integer, nullable=False, default=0)
     notifications_failed = db.Column(db.Integer, nullable=False, default=0)
 
-    processing_started = db.Column(db.DateTime, index=False, unique=False, nullable=True)
+    processing_started = db.Column(db.DateTime, index=True, unique=False, nullable=True)
     processing_finished = db.Column(db.DateTime, index=False, unique=False, nullable=True)
     created_by = db.relationship("User")
     created_by_id = db.Column(UUID(as_uuid=True), db.ForeignKey("users.id"), index=True, nullable=True)

migrations/versions/0483_index_jobs.py

@@ -0,0 +1,58 @@
+"""
+
+Revision ID: 0483_index_jobs
+Revises: 0482_index_facts
+Create Date: 2025-06-09 20:01:02.943393
+
+"""
+from alembic import op
+
+revision = '0483_index_jobs'
+down_revision = '0482_index_facts'
+
+def index_exists(name):
+    connection = op.get_bind()
+    result = connection.execute(
+        "SELECT exists(SELECT 1 from pg_indexes where indexname = '{}') as ix_exists;".format(name)
+    ).first()
+    return result.ix_exists
+
+def upgrade():
+    # PostgreSQL requires that CREATE INDEX CONCURRENTLY cannot run within a transaction.
+    # Alembic runs migrations in a transaction by default, so we need to commit the current
+    # transaction before creating indexes concurrently.
+    op.execute("COMMIT")
+    if not index_exists("ix_jobs_created_at"):
+        op.create_index(
+            op.f('ix_jobs_created_at'), 
+            'jobs', 
+            ['created_at'], 
+            unique=False, 
+            postgresql_concurrently=True
+        )
+    if not index_exists("ix_jobs_processing_started"):
+        op.create_index(
+            op.f('ix_jobs_processing_started'), 
+            'jobs', 
+            ['processing_started'], 
+            unique=False, 
+            postgresql_concurrently=True
+        )
+
+
+def downgrade():
+    # PostgreSQL requires that DROP INDEX CONCURRENTLY cannot run within a transaction.
+    # Need to commit the current transaction first.
+    op.execute("COMMIT")
+    if index_exists("ix_jobs_processing_started"):
+        op.drop_index(
+            op.f('ix_jobs_processing_started'), 
+            table_name='jobs', 
+            postgresql_concurrently=True
+        )
+    if index_exists("ix_jobs_created_at"):
+        op.drop_index(
+            op.f('ix_jobs_created_at'), 
+            table_name='jobs', 
+            postgresql_concurrently=True
+        )