Add UPLOAD_DOCUMENT to default service perms

[whabanks]

Summary | Résumé

This PR adds the upload_document setting to the list of default enabled service settings.

Related Issues | Cartes liées

• https://docs.google.com/document/d/1m_EzXNJbqjJH-WLzxRKMtO4k5CAHwk51uCXi7xJQR44/edit?pli=1&tab=t.0#task=doULW0OCbF-OneiL

Test instructions | Instructions pour tester la modification

1. Create a new service
2. Navigate to the service settings

• Note that the Send files by email setting is enabled by default

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[Copilot]

Pull request overview

This PR updates the API’s notion of “default enabled service permissions” so that newly created services include the UPLOAD_DOCUMENT permission by default (corresponding to the “Send files by email” setting in the UI).

Changes:

• Add UPLOAD_DOCUMENT to the DEFAULT_SERVICE_PERMISSIONS used when creating a new service.
• Update service REST tests to expect UPLOAD_DOCUMENT in the default permissions returned by the service endpoints.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
app/dao/services_dao.py	Adds UPLOAD_DOCUMENT to the default service permission list applied during service creation.
tests/app/service/test_rest.py	Updates assertions for default service permissions in list/detail service API tests to include UPLOAD_DOCUMENT.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.