trying to pull the migration into a single file to review#2450
Draft
P0NDER0SA wants to merge 1 commit into
Draft
trying to pull the migration into a single file to review#2450P0NDER0SA wants to merge 1 commit into
P0NDER0SA wants to merge 1 commit into
Conversation
staging/pinpoint_to_sqs_sms_callbacks Terragrunt Plan:Terraform will perform the following actions:
# aws_cloudformation_stack.pinpoint_hybrid_stack will be created
+ resource "aws_cloudformation_stack" "pinpoint_hybrid_stack" {
+ id = (known after apply)
+ name = "pinpoint-sms-bridge-stack"
+ outputs = (known after apply)
+ parameters = (known after apply)
+ policy_body = (known after apply)
+ region = "ca-central-1"
+ tags_all = (known after apply)
+ template_body = (known after apply)
}
# aws_pinpointsmsvoicev2_configuration_set.main will be created
+ resource "aws_pinpointsmsvoicev2_configuration_set" "main" {
+ arn = (known after apply)
+ id = (known after apply)
+ name = "notify-config-set"
+ region = "ca-central-1"
+ tags_all = {}
}
# aws_secretsmanager_secret.pinpoint_default_pool_id will be destroyed
# (because aws_secretsmanager_secret.pinpoint_default_pool_id is not in configuration)
- resource "aws_secretsmanager_secret" "pinpoint_default_pool_id" {
- arn = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_DEFAULT_POOL_ID-4Padlr" -> null
- force_overwrite_replica_secret = false -> null
- id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_DEFAULT_POOL_ID-4Padlr" -> null
- name = "PINPOINT_DEFAULT_POOL_ID" -> null
- recovery_window_in_days = 0 -> null
- region = "ca-central-1" -> null
- tags = {} -> null
- tags_all = {} -> null
# (4 unchanged attributes hidden)
}
# aws_secretsmanager_secret.pinpoint_shortcode_pool_id will be destroyed
# (because aws_secretsmanager_secret.pinpoint_shortcode_pool_id is not in configuration)
- resource "aws_secretsmanager_secret" "pinpoint_shortcode_pool_id" {
- arn = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_SHORT_CODE_POOL_ID-SRdXMq" -> null
- force_overwrite_replica_secret = false -> null
- id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_SHORT_CODE_POOL_ID-SRdXMq" -> null
- name = "PINPOINT_SHORT_CODE_POOL_ID" -> null
- recovery_window_in_days = 0 -> null
- region = "ca-central-1" -> null
- tags = {} -> null
- tags_all = {} -> null
# (4 unchanged attributes hidden)
}
# aws_secretsmanager_secret_version.pinpoint_default_pool_id will be destroyed
# (because aws_secretsmanager_secret_version.pinpoint_default_pool_id is not in configuration)
- resource "aws_secretsmanager_secret_version" "pinpoint_default_pool_id" {
- arn = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_DEFAULT_POOL_ID-4Padlr" -> null
- id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_DEFAULT_POOL_ID-4Padlr|terraform-20250311151412298700000003" -> null
- region = "ca-central-1" -> null
- secret_id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_DEFAULT_POOL_ID-4Padlr" -> null
- secret_string = (sensitive value) -> null
- secret_string_wo = (write-only attribute) -> null
- version_id = "terraform-20250311151412298700000003" -> null
- version_stages = [
- "AWSCURRENT",
] -> null
# (1 unchanged attribute hidden)
}
# aws_secretsmanager_secret_version.pinpoint_shortcode_pool_id will be destroyed
# (because aws_secretsmanager_secret_version.pinpoint_shortcode_pool_id is not in configuration)
- resource "aws_secretsmanager_secret_version" "pinpoint_shortcode_pool_id" {
- arn = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_SHORT_CODE_POOL_ID-SRdXMq" -> null
- id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_SHORT_CODE_POOL_ID-SRdXMq|terraform-20250311151412298800000004" -> null
- region = "ca-central-1" -> null
- secret_id = "arn:aws:secretsmanager:ca-central-1:239043911459:secret:PINPOINT_SHORT_CODE_POOL_ID-SRdXMq" -> null
- secret_string = (sensitive value) -> null
- secret_string_wo = (write-only attribute) -> null
- version_id = "terraform-20250311151412298800000004" -> null
- version_stages = [
- "AWSCURRENT",
] -> null
# (1 unchanged attribute hidden)
}
# aws_sns_topic.sms_events will be created
+ resource "aws_sns_topic" "sms_events" {
+ arn = (known after apply)
+ beginning_archive_time = (known after apply)
+ content_based_deduplication = false
+ fifo_throughput_scope = (known after apply)
+ fifo_topic = false
+ id = (known after apply)
+ name = "pinpoint-sms-events"
+ name_prefix = (known after apply)
+ owner = (known after apply)
+ policy = (known after apply)
+ region = "ca-central-1"
+ signature_version = (known after apply)
+ tags_all = (known after apply)
+ tracing_config = (known after apply)
}
# aws_sns_topic_subscription.sms_to_sqs will be created
+ resource "aws_sns_topic_subscription" "sms_to_sqs" {
+ arn = (known after apply)
+ confirmation_timeout_in_minutes = 1
+ confirmation_was_authenticated = (known after apply)
+ endpoint = (known after apply)
+ endpoint_auto_confirms = false
+ filter_policy_scope = (known after apply)
+ id = (known after apply)
+ owner_id = (known after apply)
+ pending_confirmation = (known after apply)
+ protocol = "sqs"
+ raw_message_delivery = false
+ region = "ca-central-1"
+ topic_arn = (known after apply)
}
# aws_sqs_queue.sms_callbacks will be created
+ resource "aws_sqs_queue" "sms_callbacks" {
+ arn = (known after apply)
+ content_based_deduplication = false
+ deduplication_scope = (known after apply)
+ delay_seconds = 0
+ fifo_queue = false
+ fifo_throughput_limit = (known after apply)
+ id = (known after apply)
+ kms_data_key_reuse_period_seconds = (known after apply)
+ max_message_size = 262144
+ message_retention_seconds = 345600
+ name = "pinpoint-sms-callbacks-queue"
+ name_prefix = (known after apply)
+ policy = (known after apply)
+ receive_wait_time_seconds = 0
+ redrive_allow_policy = (known after apply)
+ redrive_policy = (known after apply)
+ region = "ca-central-1"
+ sqs_managed_sse_enabled = (known after apply)
+ tags_all = (known after apply)
+ url = (known after apply)
+ visibility_timeout_seconds = 30
}
# aws_sqs_queue_policy.sns_to_sqs will be created
+ resource "aws_sqs_queue_policy" "sns_to_sqs" {
+ id = (known after apply)
+ policy = (known after apply)
+ queue_url = (known after apply)
+ region = "ca-central-1"
}
# null_resource.create_pinpoint_configuration_set will be destroyed
# (because null_resource.create_pinpoint_configuration_set is not in configuration)
- resource "null_resource" "create_pinpoint_configuration_set" {
- id = "1475774052149741967" -> null
}
# null_resource.create_pools will be destroyed
# (because null_resource.create_pools is not in configuration)
- resource "null_resource" "create_pools" {
- id = "3982324257624334099" -> null
}
Plan: 6 to add, 0 to change, 6 to destroy.
# --- End of Plan 1 ---
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+121
to
+123
| resource "aws_sqs_queue" "sms_callbacks" { | ||
| name = "pinpoint-sms-callbacks-queue" | ||
| } |
Check failure
Code scanning / checkov
Ensure all data stored in the SQS queue is encrypted Error
staging/ses_to_sqs_email_callbacks Terragrunt Plan:Terraform will perform the following actions:
# module.ses_to_sqs_email_callbacks.aws_lambda_function.this will be updated in-place
~ resource "aws_lambda_function" "this" {
- description = "2026-03-31T13:32:09Z" -> null
id = "ses_to_sqs_email_callbacks"
tags = {
"CostCentre" = "notification-canada-ca-staging"
"Terraform" = "true"
}
# (29 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
# --- End of Plan 1 ---
|
staging/heartbeat Terragrunt Plan:Terraform will perform the following actions:
# module.heartbeat.aws_lambda_function.this will be updated in-place
~ resource "aws_lambda_function" "this" {
- description = "2026-03-31T13:31:50Z" -> null
id = "heartbeat"
tags = {
"CostCentre" = "notification-canada-ca-staging"
"Terraform" = "true"
}
# (29 unchanged attributes hidden)
# (4 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
# --- End of Plan 1 ---
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
TODO: 1-3 sentence description of the changed you're proposing.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur