feat: notification v3#6824
Open
thiessenp-cds wants to merge 63 commits into
Open
Conversation
…tform-forms-client into feat/notification-v3
Contributor
🧪 Review environmenthttps://7ij3htokkf7djda2zmzrerkabq0gnkng.lambda-url.ca-central-1.on.aws/ |
github-actions
Bot
added
the
!! Package Update !!
thiessenp-cds
changed the title
thiessenp-cds
commented
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot be deployed in either environment (Staging/Production) until cds-snc/forms-terraform#1137 is deployed
Summary | Résumé
Adds the new notification pipeline to GC Forms. The big advantage is allowing emails to be sent deferred once submission processing is complete e.g. a submission with a file attachment. The file attachment case previously caused a confirmation email to be sent while the submission was often still being processed and not available - leading to confusion. The deferred option solves that. An immediate notification can also be called.
One of the big "infra" related changes is calling the GC Notify API on the infra side vs. in the App. This will add more opportunities for monitoring and tracking down issues like timeout errors.
This PR also updates all email sending to use the new notification pipeline by updating sendEmail to use it by default. One exception is the 2FA uses the option to force sending email direct to GC Notify. Once the notify pipeline is shown to be very stable 2FA can use it as well.
The feature is feature flagged. ON will send emails through the Notification pipeline. OFFwill send direct to GC Notify.
Note: Requires cds-snc/forms-terraform#1137
Note: This PR updates Notifications to use the new push notification found in @gcforms/connector. See the related infra PR for more info #1137