document windows compilation#1465
Open
gogo2464 wants to merge 1 commit into
Open
Conversation
Contributor
|
Using setup.py directly is now deprecated by Python. Everything should work if you run |
Author
|
my bad! I can fix it |
Contributor
|
I think we have someone who is currently updating to the setup.py replacement |
Contributor
|
Technically it’s not necessary to get rid of setup.py (and honestly I wouldn’t recommend it). I tried locally to create a spec-compliant project.toml that uses the current setup.py, but everything exploded because Python doesn’t properly support some of the constructs used anymore 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.