Skip to content

Commit 35ac789

Browse files
committed
fix file-merge didn't work correct
1 parent 99c6cd4 commit 35ac789

5 files changed

Lines changed: 12 additions & 5 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<modelVersion>4.0.0</modelVersion>
33
<groupId>de.oppermann.pomutils</groupId>
44
<artifactId>pomutils</artifactId>
5-
<version>1.0</version>
5+
<version>1.1</version>
66

77
<licenses>
88
<license>

src/main/java/de/oppermann/pomutils/PomMergeDriver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void adjustTheirPomVersion() {
5555
}
5656

5757
public int doGitMerge() {
58-
ProcessBuilder processBuilder = new ProcessBuilder("git", "merge-file", "-p", "-L", "our", "-L", "base", "-L", "theirs", ourPom.getPath(),
58+
ProcessBuilder processBuilder = new ProcessBuilder("git", "merge-file", "-L", "our", "-L", "base", "-L", "theirs", ourPom.getPath(),
5959
basePom.getPath(), theirPom.getPath());
6060
processBuilder.redirectErrorStream(true);
6161
try {

src/test/java/de/oppermann/pomutils/PomMergeDriverTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import junit.framework.TestCase;
2525

2626
import org.apache.commons.io.FileUtils;
27+
import org.codehaus.mojo.versions.api.PomHelper;
2728

2829
import de.oppermann.pomutils.util.POM;
2930

@@ -55,11 +56,17 @@ public void testAutoMergeSucceded() throws Exception {
5556
int mergeReturnValue = pomMergeDriver.doGitMerge();
5657

5758
assertTrue("merge succeeded", mergeReturnValue == 0);
58-
59+
5960
POM theirPom = new POM(theirPomFile);
6061
POM ourPom = new POM(ourPomFile);
6162

6263
assertEquals("same version now", ourPom.getProjectVersion(), theirPom.getProjectVersion());
64+
65+
66+
String theirDependecyVersoin = PomHelper.getRawModel(new File(theirPomFile)).getDependencies().get(0).getVersion();
67+
String ourDependencyVersion = PomHelper.getRawModel(new File(ourPomFile)).getDependencies().get(0).getVersion();
68+
69+
assertEquals("dependency version change merged", theirDependecyVersoin, ourDependencyVersion);
6370
}
6471

6572
public void testAutoMergeFailed() throws Exception {

src/test/resources/merge/autoMergeSucceded/our.pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<dependency>
88
<groupId>org.codehaus.mojo</groupId>
99
<artifactId>versions-maven-plugin</artifactId>
10-
<version>2.5</version>
10+
<version>2.1</version>
1111
<type>maven-plugin</type>
1212
</dependency>
1313
</dependencies>

src/test/resources/merge/autoMergeSucceded/their.pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<dependency>
88
<groupId>org.codehaus.mojo</groupId>
99
<artifactId>versions-maven-plugin</artifactId>
10-
<version>2.1</version>
10+
<version>2.5</version>
1111
<type>maven-plugin</type>
1212
</dependency>
1313
</dependencies>

0 commit comments

Comments
 (0)