Use resource_name instead of resource object#114
Merged
RenzoMinelli merged 5 commits intomasterfrom Feb 6, 2026
Merged
Conversation
RenzoMinelli
force-pushed
the
rm/stop-requiring-resource
branch
from
684d416 to
8573aa9
Compare
RenzoMinelli
commented
Feb 5, 2026
| @@ -1,4 +1,4 @@ | |||
| <%= passkey_creation_form_for(resource) do |form| %> | |||
| <%= passkey_creation_form_for(resource_name) do |form| %> | |||
Contributor
Author
There was a problem hiding this comment.
For these views that are included in the gem we still need to get the resource name from the view
Collaborator
There was a problem hiding this comment.
That makes sense because on our views we are sure that we are in Devise context so resource should be available
santiagorodriguez96
approved these changes
Feb 5, 2026
santiagorodriguez96
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use resource_name instead of resource object as this is a non authenticated controller. We still need the resource name to correctly generate the path and the dynamic method we made supports both a resource and a scope