Skip to content

Fix namespace of js configiration generator #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquintomas2003 merged 2 commits into from
Feb 10, 2026
Merged

Fix namespace of js configiration generator #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea4e26
Fix namespace of js configiration generator
joaquintomas2003 Feb 7, 2026
8939a8d
Update changelog
joaquintomas2003 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixed

- Fix `install_generator` invoking missing `devise:webauthn:javascript` task. [#118](https://github.com/cedarcode/devise-webauthn/pull/118) [@joaquintomas2003]

## [v0.3.0](https://github.com/cedarcode/devise-webauthn/compare/v0.2.2...v0.3.0/) - 2026-01-16

### Added
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/devise/webauthn/install/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def generate_webauthn_id_column
end

def generate_javascript_configuration
invoke "devise:webauthn:javascript"
invoke "devise:webauthn:javascript_configuration"
end

def final_message
Expand Down
1 change: 0 additions & 1 deletion ...ipt/javascript_configuration_generator.rb → ...ion/javascript_configuration_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ module Devise
module Webauthn
class JavascriptConfigurationGenerator < Rails::Generators::Base
hide!
namespace "devise:webauthn:javascript"

desc "Configure JavaScript loading for devise-webauthn"

Expand Down
2 changes: 1 addition & 1 deletion spec/generators/devise/webauthn/install_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "invokes the javascript configuration generator" do
expect(generator).to have_received(:invoke)
.with("devise:webauthn:javascript")
.with("devise:webauthn:javascript_configuration")
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/generators/devise/webauthn/javascript_configuration_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require "spec_helper"
require "generators/devise/webauthn/javascript/javascript_configuration_generator"
require "generators/devise/webauthn/javascript_configuration/javascript_configuration_generator"

RSpec.describe Devise::Webauthn::JavascriptConfigurationGenerator, type: :generator do
tests described_class
Expand Down