Small CHANGELOG adjustments#130
Merged
santiagorodriguez96 merged 3 commits intomasterfrom Mar 6, 2026
Merged
Conversation
It makes more sense to have the entry that changes the name of the methods above the entry that referenced the new names of such methods.
Comment on lines
15
to
23
| ```erb | ||
| <%# Before %> | ||
| <%= passkey_creation_form_for(:user, form_classes: "my-class") do |form| %> | ||
| ... | ||
| <% end %> | ||
| <%= login_with_passkey_button(:user, "Log in with passkeys") %> | ||
|
|
||
| <%# After %> | ||
| <%= passkey_creation_form_for(:user, class: "my-class", id: "my-form", data: { turbo: false }) do |form| %> | ||
| ... | ||
| <%= login_with_passkey_form_for(:user) do |form| %> | ||
| <%= form.submit "Log in with passkeys" %> | ||
| <% end %> | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
I wonder if we should really add these code examples to the CHANGELOG 🤔
Feels to me that users could go to the linked PR for more info.
Anyway not a blocker, I'm fine with keeping this as it is 👍
RenzoMinelli
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.