Form helpers should not be the ones storing the challenge in the session#73
Conversation
2b0ce3c to
686ebc9
Compare
0350783 to
da88872
Compare
da88872 to
bec8cbd
Compare
bec8cbd to
07b1d33
Compare
07b1d33 to
d5dd6a6
Compare
…the-challenge-in-helper
4445c4d to
13cf467
Compare
e8e2643 to
ec11bd4
Compare
ec11bd4 to
5523100
Compare
RenzoMinelli
left a comment
There was a problem hiding this comment.
Have you considered grouping these controllers under different modules/folders, something like this:
passkey
- registration_options_controller
- authentication_options_controller
security_key
- registration_options_controller
- authentication_options_controller
…the-challenge-in-helper
…the-challenge-in-helper
@RenzoMinelli Done in chore: scope options controllers under passkey and security_key |
Talked offline and the controller generation from templates doesn't work
Fixed in 8c5ede6 I've tested it using our demo app :) |
|
After try this out on our demo app. I noticed that overriding the options controller routes would require something like this: Rails.application.routes.draw do
devise_for :users, controllers: {
"passkey/authentication_options": 'users/passkey_authentication_options'
}
endWhich, IMO, isn’t very user friendly. To avoid forcing users into this setup, I reverted the changes and kept the controllers as they were before. |
Closes #53