test: add specs for subject graph feature

Component specs (11):
- Node data serialization (id, code, name, url, availability)
- Edge extraction from prerequisites (subject, logical/AND, external)
- Semester label generation (curriculum categories, planner map)
- Empty state handling

System specs - Planner Graph (6):
- Graph rendering with planned subjects and edges
- Empty state with link to add subjects
- Legend with highlight indicators (Previa, Dependiente)
- Interaction instructions text
- Available subject marking

System specs - Subjects Graph (7):
- Category filtering (single, multiple)
- Edge rendering within filtered subjects
- Empty state when no categories
- Full legend display (all 5 indicators)
- Interaction instructions text
- Available subjects based on user approvals

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: RenzoMinelli

spec/components/subject_graph_component_spec.rb

@@ -0,0 +1,160 @@
+require "rails_helper"
+
+RSpec.describe SubjectGraphComponent, type: :component do
+  let(:user) { build_stubbed(:user) }
+  let(:student) { UserStudent.new(user) }
+
+  context "with subjects" do
+    it "renders the graph container with data attributes" do
+      subject1 = create(:subject, name: "Subject 1", code: "S1")
+
+      render_inline(described_class.new(subjects: [subject1], current_student: student))
+
+      expect(page).to have_css "[data-controller='subject-graph']"
+      expect(page).to have_css "[data-subject-graph-nodes-value]"
+      expect(page).to have_css "[data-subject-graph-edges-value]"
+    end
+
+    it "includes subject data in nodes" do
+      subject1 = create(:subject, name: "Test Subject", short_name: "TS", code: "TS1")
+
+      render_inline(described_class.new(subjects: [subject1], current_student: student))
+
+      node_data = page.find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+      nodes = JSON.parse(node_data)
+
+      expect(nodes.length).to eq(1)
+      expect(nodes.first["id"]).to eq(subject1.id)
+      expect(nodes.first["code"]).to eq("TS1")
+      expect(nodes.first["name"]).to eq("TS")
+      expect(nodes.first["url"]).to eq("/materias/#{subject1.id}")
+    end
+
+    it "uses full name when short_name is not present" do
+      subject1 = create(:subject, name: "Full Name Subject", short_name: nil, code: "FN1")
+
+      render_inline(described_class.new(subjects: [subject1], current_student: student))
+
+      node_data = page.find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+      nodes = JSON.parse(node_data)
+
+      expect(nodes.first["name"]).to eq("Full Name Subject")
+    end
+
+    it "marks available subjects as available" do
+      subject1 = create(:subject, name: "Available Subject", code: "AV1")
+
+      render_inline(described_class.new(subjects: [subject1], current_student: student))
+
+      node_data = page.find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+      nodes = JSON.parse(node_data)
+
+      expect(nodes.first["available"]).to be true
+    end
+  end
+
+  context "with prerequisites" do
+    it "creates edges for subject prerequisites within the subject set" do
+      subject1 = create(:subject, name: "Prereq", code: "PR1")
+      subject2 = create(:subject, name: "Dependent", code: "DE1")
+
+      create(:subject_prerequisite, approvable: subject2.course, approvable_needed: subject1.course)
+
+      render_inline(described_class.new(subjects: [subject1, subject2], current_student: student))
+
+      edge_data = page.find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+      edges = JSON.parse(edge_data)
+
+      expect(edges.length).to eq(1)
+      expect(edges.first["source"]).to eq(subject1.id)
+      expect(edges.first["target"]).to eq(subject2.id)
+    end
+
+    it "does not create edges for prerequisites outside the subject set" do
+      subject1 = create(:subject, name: "Outside", code: "OU1")
+      subject2 = create(:subject, name: "Inside", code: "IN1")
+
+      create(:subject_prerequisite, approvable: subject2.course, approvable_needed: subject1.course)
+
+      # Only include subject2, not subject1
+      render_inline(described_class.new(subjects: [subject2], current_student: student))
+
+      edge_data = page.find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+      edges = JSON.parse(edge_data)
+
+      expect(edges).to be_empty
+    end
+
+    it "handles logical prerequisites with multiple operands" do
+      subject1 = create(:subject, name: "Prereq 1", code: "PR1")
+      subject2 = create(:subject, name: "Prereq 2", code: "PR2")
+      subject3 = create(:subject, name: "Dependent", code: "DE1")
+
+      create(:and_prerequisite, approvable: subject3.course, operands_prerequisites: [
+        create(:subject_prerequisite, approvable_needed: subject1.course),
+        create(:subject_prerequisite, approvable_needed: subject2.course),
+      ])
+
+      render_inline(described_class.new(subjects: [subject1, subject2, subject3], current_student: student))
+
+      edge_data = page.find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+      edges = JSON.parse(edge_data)
+
+      expect(edges.length).to eq(2)
+      sources = edges.map { |e| e["source"] }
+      expect(sources).to contain_exactly(subject1.id, subject2.id)
+      expect(edges.all? { |e| e["target"] == subject3.id }).to be true
+    end
+  end
+
+  context "semester labels" do
+    it "renders semester-labels data attribute" do
+      subject1 = create(:subject, name: "Subject 1", code: "S1", category: "first_semester")
+
+      render_inline(described_class.new(subjects: [subject1], current_student: student))
+
+      expect(page).to have_css "[data-subject-graph-semester-labels-value]"
+    end
+
+    it "produces correct labels for curriculum graph" do
+      subject1 = create(:subject, name: "Subject 1", code: "S1", category: "first_semester")
+      subject2 = create(:subject, name: "Subject 2", code: "S2", category: "second_semester")
+
+      render_inline(described_class.new(subjects: [subject1, subject2], current_student: student))
+
+      labels_data = page.find("[data-subject-graph-semester-labels-value]")["data-subject-graph-semester-labels-value"]
+      labels = JSON.parse(labels_data)
+
+      expect(labels["1"]).to eq("Primer semestre")
+      expect(labels["2"]).to eq("Segundo semestre")
+    end
+
+    it "produces correct labels for planner graph with semester_map" do
+      subject1 = create(:subject, name: "Subject 1", code: "S1")
+      subject2 = create(:subject, name: "Subject 2", code: "S2")
+
+      semester_map = { subject1.id => 3, subject2.id => 5 }
+
+      render_inline(described_class.new(subjects: [subject1, subject2], current_student: student,
+                                        semester_map: semester_map))
+
+      labels_data = page.find("[data-subject-graph-semester-labels-value]")["data-subject-graph-semester-labels-value"]
+      labels = JSON.parse(labels_data)
+
+      expect(labels["3"]).to eq("Semestre 3")
+      expect(labels["5"]).to eq("Semestre 5")
+    end
+  end
+
+  context "without subjects" do
+    it "renders empty arrays for nodes and edges" do
+      render_inline(described_class.new(subjects: [], current_student: student))
+
+      node_data = page.find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+      edge_data = page.find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+
+      expect(JSON.parse(node_data)).to be_empty
+      expect(JSON.parse(edge_data)).to be_empty
+    end
+  end
+end

spec/system/planner_graph_spec.rb

@@ -0,0 +1,90 @@
+require 'rails_helper'
+
+RSpec.describe "Planner Graph", type: :system do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in user
+  end
+
+  it "displays graph with planned subjects" do
+    subject1 = create(:subject, name: "Calculo 1", code: "C1")
+    subject2 = create(:subject, name: "Calculo 2", code: "C2")
+
+    create(:subject_prerequisite, approvable: subject2.course, approvable_needed: subject1.course)
+
+    create(:subject_plan, user: user, subject: subject1, semester: 1)
+    create(:subject_plan, user: user, subject: subject2, semester: 2)
+
+    visit planner_graph_path
+
+    expect(page).to have_css "[data-controller='subject-graph']"
+    expect(page).to have_css "[data-subject-graph-nodes-value]"
+    expect(page).to have_css "[data-subject-graph-edges-value]"
+    expect(page).to have_css "[data-subject-graph-semester-labels-value]"
+
+    node_data = find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+    nodes = JSON.parse(node_data)
+
+    expect(nodes.length).to eq(2)
+    expect(nodes.map { |n| n["code"] }).to contain_exactly("C1", "C2")
+  end
+
+  it "shows empty state when no planned subjects" do
+    visit planner_graph_path
+
+    expect(page).to have_text "No tienes materias planificadas"
+    expect(page).to have_link "Agregar materias"
+  end
+
+  it "includes edges for prerequisites within planned subjects" do
+    subject1 = create(:subject, name: "Base", code: "B1")
+    subject2 = create(:subject, name: "Advanced", code: "A1")
+
+    create(:subject_prerequisite, approvable: subject2.course, approvable_needed: subject1.course)
+
+    create(:subject_plan, user: user, subject: subject1, semester: 1)
+    create(:subject_plan, user: user, subject: subject2, semester: 2)
+
+    visit planner_graph_path
+
+    edge_data = find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+    edges = JSON.parse(edge_data)
+
+    expect(edges.length).to eq(1)
+    expect(edges.first["source"]).to eq(subject1.id)
+    expect(edges.first["target"]).to eq(subject2.id)
+  end
+
+  it "displays legend with highlight indicators" do
+    subject1 = create(:subject, name: "Subject", code: "S1")
+    create(:subject_plan, user: user, subject: subject1, semester: 1)
+
+    visit planner_graph_path
+
+    expect(page).to have_text "Previa"
+    expect(page).to have_text "Dependiente"
+  end
+
+  it "displays interaction instructions" do
+    subject1 = create(:subject, name: "Subject", code: "S1")
+    create(:subject_plan, user: user, subject: subject1, semester: 1)
+
+    visit planner_graph_path
+
+    expect(page).to have_text("previas", normalize_ws: true)
+  end
+
+  it "marks available subjects in the graph data" do
+    subject1 = create(:subject, name: "Available", code: "AV")
+    create(:subject_plan, user: user, subject: subject1, semester: 1)
+
+    visit planner_graph_path
+
+    node_data = find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+    nodes = JSON.parse(node_data)
+
+    available_node = nodes.find { |n| n["code"] == "AV" }
+    expect(available_node["available"]).to be true
+  end
+end

spec/system/subjects_graph_spec.rb

@@ -0,0 +1,107 @@
+require 'rails_helper'
+
+RSpec.describe "Subjects Graph", type: :system do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in user
+  end
+
+  it "displays graph filtered by single category" do
+    create(:subject, name: "First Sem Subject", code: "FS1", category: "first_semester")
+    create(:subject, name: "Second Sem Subject", code: "SS1", category: "second_semester")
+
+    visit subjects_graph_path(categories: ["first_semester"])
+
+    expect(page).to have_css "[data-controller='subject-graph']"
+    expect(page).to have_css "[data-subject-graph-semester-labels-value]"
+
+    node_data = find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+    nodes = JSON.parse(node_data)
+
+    expect(nodes.length).to eq(1)
+    expect(nodes.first["code"]).to eq("FS1")
+  end
+
+  it "displays graph filtered by multiple categories" do
+    create(:subject, name: "First Sem Subject", code: "FS1", category: "first_semester")
+    create(:subject, name: "Second Sem Subject", code: "SS1", category: "second_semester")
+    create(:subject, name: "Third Sem Subject", code: "TS1", category: "third_semester")
+
+    visit subjects_graph_path(categories: ["first_semester", "second_semester"])
+
+    node_data = find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+    nodes = JSON.parse(node_data)
+
+    expect(nodes.length).to eq(2)
+    expect(nodes.map { |n| n["code"] }).to contain_exactly("FS1", "SS1")
+  end
+
+  it "shows edges for prerequisites within filtered subjects" do
+    subject1 = create(:subject, name: "Intro", code: "IN1", category: "first_semester")
+    subject2 = create(:subject, name: "Advanced", code: "AD1", category: "first_semester")
+
+    create(:subject_prerequisite, approvable: subject2.course, approvable_needed: subject1.course)
+
+    visit subjects_graph_path(categories: ["first_semester"])
+
+    edge_data = find("[data-subject-graph-edges-value]")["data-subject-graph-edges-value"]
+    edges = JSON.parse(edge_data)
+
+    expect(edges.length).to eq(1)
+    expect(edges.first["source"]).to eq(subject1.id)
+    expect(edges.first["target"]).to eq(subject2.id)
+  end
+
+  it "shows empty state when no categories provided" do
+    create(:subject, name: "Some Subject", code: "SS1", category: "first_semester")
+
+    visit subjects_graph_path
+
+    expect(page).to have_text "No hay materias para mostrar"
+  end
+
+  it "displays legend with all state and highlight indicators" do
+    create(:subject, name: "Subject", code: "S1", category: "first_semester")
+
+    visit subjects_graph_path(categories: ["first_semester"])
+
+    expect(page).to have_text "No disponible"
+    expect(page).to have_text "Disponible"
+    expect(page).to have_text "Completada"
+    expect(page).to have_text "Previa"
+    expect(page).to have_text "Dependiente"
+  end
+
+  it "displays interaction instructions" do
+    create(:subject, name: "Subject", code: "S1", category: "first_semester")
+
+    visit subjects_graph_path(categories: ["first_semester"])
+
+    expect(page).to have_text("previas", normalize_ws: true)
+  end
+
+  it "marks available subjects based on user approvals" do
+    prereq_subject = create(:subject, name: "Prerequisite", code: "PR1", category: "first_semester")
+    dependent_subject = create(:subject, name: "Dependent", code: "DE1", category: "first_semester")
+
+    create(:subject_prerequisite, approvable: dependent_subject.course, approvable_needed: prereq_subject.course)
+
+    # Approve the prerequisite
+    user.approvals << prereq_subject.course.id
+    user.save!
+
+    visit subjects_graph_path(categories: ["first_semester"])
+
+    node_data = find("[data-subject-graph-nodes-value]")["data-subject-graph-nodes-value"]
+    nodes = JSON.parse(node_data)
+
+    prereq_node = nodes.find { |n| n["code"] == "PR1" }
+    dependent_node = nodes.find { |n| n["code"] == "DE1" }
+
+    # Prereq has no prereqs, so it's available
+    expect(prereq_node["available"]).to be true
+    # Dependent should now be available since prereq is approved
+    expect(dependent_node["available"]).to be true
+  end
+end