Merge pull request #370 from 8ma10s/support_for_authenticator_attachment_in_public_key_credential

Add support for optional authenticator_attachment in PublicKeyCredential

Author: santiagorodriguez96

lib/webauthn/fake_client.rb

@@ -64,6 +64,7 @@ def create(
         "type" => "public-key",
         "id" => internal_encoder.encode(id),
         "rawId" => encoder.encode(id),
+        "authenticatorAttachment" => 'platform',
         "clientExtensionResults" => extensions,
         "response" => {
           "attestationObject" => encoder.encode(attestation_object),
@@ -108,6 +109,7 @@ def get(challenge: fake_challenge,
         "id" => internal_encoder.encode(assertion[:credential_id]),
         "rawId" => encoder.encode(assertion[:credential_id]),
         "clientExtensionResults" => extensions,
+        "authenticatorAttachment" => 'platform',
         "response" => {
           "clientDataJSON" => encoder.encode(client_data_json),
           "authenticatorData" => encoder.encode(assertion[:authenticator_data]),

lib/webauthn/public_key_credential.rb

@@ -4,14 +4,15 @@
 
 module WebAuthn
   class PublicKeyCredential
-    attr_reader :type, :id, :raw_id, :client_extension_outputs, :response
+    attr_reader :type, :id, :raw_id, :client_extension_outputs, :authenticator_attachment, :response
 
     def self.from_client(credential, relying_party: WebAuthn.configuration.relying_party)
       new(
         type: credential["type"],
         id: credential["id"],
         raw_id: relying_party.encoder.decode(credential["rawId"]),
         client_extension_outputs: credential["clientExtensionResults"],
+        authenticator_attachment: credential["authenticatorAttachment"],
         response: response_class.from_client(credential["response"], relying_party: relying_party),
         relying_party: relying_party
       )
@@ -22,13 +23,15 @@ def initialize(
       id:,
       raw_id:,
       response:,
+      authenticator_attachment: nil,
       client_extension_outputs: {},
       relying_party: WebAuthn.configuration.relying_party
     )
       @type = type
       @id = id
       @raw_id = raw_id
       @client_extension_outputs = client_extension_outputs
+      @authenticator_attachment = authenticator_attachment
       @response = response
       @relying_party = relying_party
     end

spec/webauthn/public_key_credential_with_assertion_spec.rb

@@ -21,6 +21,7 @@
     let(:credential_raw_id) { credential[0] }
     let(:credential_id) { Base64.urlsafe_encode64(credential_raw_id) }
     let(:credential_type) { "public-key" }
+    let(:credential_authenticator_attachment) { 'platform' }
     let(:credential_public_key) { Base64.urlsafe_encode64(credential[1]) }
     let(:credential_sign_count) { credential[2] }
 
@@ -39,6 +40,7 @@
         type: credential_type,
         id: credential_id,
         raw_id: credential_raw_id,
+        authenticator_attachment: credential_authenticator_attachment,
         response: assertion_response
       )
     end

spec/webauthn/public_key_credential_with_attestation_spec.rb

@@ -15,13 +15,15 @@
         type: type,
         id: id,
         raw_id: raw_id,
+        authenticator_attachment: authenticator_attachment,
         response: attestation_response
       )
     end
 
     let(:type) { "public-key" }
     let(:id) { Base64.urlsafe_encode64(raw_id) }
     let(:raw_id) { SecureRandom.random_bytes(16) }
+    let(:authenticator_attachment) { 'platform' }
 
     let(:attestation_response) do
       response = client.create(challenge: raw_challenge)["response"]