chore: avoid defining the struct globally

Author: nicolastemciuc

spec/webauthn/relying_party_spec.rb

@@ -5,10 +5,9 @@
 require "webauthn/fake_client"
 require "webauthn/relying_party"
 
-Credential = Struct.new(:webauthn_id, :public_key, :sign_count, keyword_init: true)
-User = Struct.new(:id, :name, :credentials, keyword_init: true)
-
 RSpec.describe "RelyingParty" do
+  let(:credential_klass) { Struct.new(:webauthn_id, :public_key, :sign_count, keyword_init: true) }
+
   let(:authenticator) { WebAuthn::FakeAuthenticator.new }
 
   let(:admin_rp) do
@@ -23,7 +22,8 @@
   end
 
   let(:user) do
-    User.new(id: WebAuthn.generate_user_id, name: 'John Doe', credentials: [])
+    user_klass = Struct.new(:id, :name, :credentials, keyword_init: true)
+    user_klass.new(id: WebAuthn.generate_user_id, name: 'John Doe', credentials: [])
   end
 
   describe '#verify_registration' do
@@ -78,7 +78,7 @@
     let(:admin_credential_public_key) { admin_credential[1] }
 
     before do
-      user.credentials << Credential.new(
+      user.credentials << credential_klass.new(
         webauthn_id: admin_credential.first,
         public_key: admin_rp.encoder.encode(admin_credential[1]),
         sign_count: 0
@@ -196,12 +196,12 @@
       end
 
       before do
-        user.credentials << Credential.new(
+        user.credentials << credential_klass.new(
           webauthn_id: admin_credential.first,
           public_key: admin_rp.encoder.encode(admin_credential[1]),
           sign_count: 0
         )
-        user.credentials << Credential.new(
+        user.credentials << credential_klass.new(
           webauthn_id: consumer_credential.first,
           public_key: consumer_rp.encoder.encode(consumer_credential[1]),
           sign_count: 0
@@ -326,12 +326,12 @@
       end
 
       before do
-        user.credentials << Credential.new(
+        user.credentials << credential_klass.new(
           webauthn_id: admin_credential.first,
           public_key: admin_rp.encoder.encode(admin_credential[1]),
           sign_count: 0
         )
-        user.credentials << Credential.new(
+        user.credentials << credential_klass.new(
           webauthn_id: default_configuration_credential.first,
           public_key: WebAuthn.configuration.encoder.encode(default_configuration_credential[1]),
           sign_count: 0
@@ -421,7 +421,7 @@
       end
 
       before do
-        user.credentials << Credential.new(
+        user.credentials << credential_klass.new(
           webauthn_id: default_configuration_credential.first,
           public_key: WebAuthn.configuration.encoder.encode(default_configuration_credential[1]),
           sign_count: 0