Skip to content

Commit ce56271

Browse files
chore: use :all instead of :allow_all
1 parent 00763f3 commit ce56271

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ WebAuthn.configure do |config|
128128
#
129129
# (C) Allow all top-level origins:
130130
#
131-
# config.allowed_top_origins = :allow_all
131+
# config.allowed_top_origins = :all
132132
#
133133
# Note: if `verify_cross_origin` is not enabled, any values set in `allowed_top_origins`
134134
# will be ignored.

lib/webauthn/authenticator_response.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def valid_token_binding?
8989
def valid_top_origin?
9090
return false unless client_data.cross_origin && client_data.top_origin
9191

92-
relying_party.allowed_top_origins == :allow_all ||
92+
relying_party.allowed_top_origins == :all ||
9393
relying_party.allowed_top_origins&.include?(client_data.top_origin)
9494
end
9595

spec/webauthn/authenticator_assertion_response_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,8 @@
449449
end
450450
end
451451

452-
context "when allowed_top_origins is :allow_all" do
453-
let(:allowed_top_origins) { :allow_all }
452+
context "when allowed_top_origins is :all" do
453+
let(:allowed_top_origins) { :all }
454454

455455
context "when cross_origin is true" do
456456
let(:cross_origin) { true }
@@ -633,8 +633,8 @@
633633
end
634634
end
635635

636-
context "when allowed_top_origins is :allow_all" do
637-
let(:allowed_top_origins) { :allow_all }
636+
context "when allowed_top_origins is :all" do
637+
let(:allowed_top_origins) { :all }
638638

639639
context "when cross_origin is true" do
640640
let(:cross_origin) { true }

spec/webauthn/authenticator_attestation_response_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -778,8 +778,8 @@
778778
end
779779
end
780780

781-
context "when allowed_top_origins is :allow_all" do
782-
let(:allowed_top_origins) { :allow_all }
781+
context "when allowed_top_origins is :all" do
782+
let(:allowed_top_origins) { :all }
783783

784784
context "when cross_origin is true" do
785785
let(:cross_origin) { true }
@@ -962,8 +962,8 @@
962962
end
963963
end
964964

965-
context "when allowed_top_origins is :allow_all" do
966-
let(:allowed_top_origins) { :allow_all }
965+
context "when allowed_top_origins is :all" do
966+
let(:allowed_top_origins) { :all }
967967

968968
context "when cross_origin is true" do
969969
let(:cross_origin) { true }

0 commit comments

Comments
 (0)