Skip to content

fix docs: update deprecated origin and verify_registration usage #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santiagorodriguez96 merged 2 commits into from
Jul 21, 2025
Merged

fix docs: update deprecated origin and verify_registration usage #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cae1d51
docs: fix deprecated origin with allowed_origins
ikea-dless Jul 18, 2025
5c78886
docs: fix verify_registration to use session[:creation_challenge]
ikea-dless Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/advanced_configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ Instead of the [Global Configuration](../README.md#configuration) you place in `
relying_party = WebAuthn::RelyingParty.new(
# This value needs to match `window.location.origin` evaluated by
# the User Agent during registration and authentication ceremonies.
origin: "https://admin.example.com",
# Multiple origins can be used when needed. Using more than one will imply you MUST configure rp_id explicitely. If you need your credentials to be bound to a single origin but you have more than one tenant, please see [our Advanced Configuration section](https://github.com/cedarcode/webauthn-ruby/blob/master/docs/advanced_configuration.md) instead of adding multiple origins.
allowed_origins: ["https://admin.example.com"],

# Relying Party name for display purposes
name: "Admin Site for Example Inc."
Expand Down Expand Up @@ -101,7 +102,7 @@ session[:creation_challenge] = options.challenge
begin
webauthn_credential = relying_party.verify_registration(
params[:publicKeyCredential],
params[:create_challenge]
session[:creation_challenge]
)

# Store Credential ID, Credential Public Key and Sign Count for future authentications
Expand Down