Skip to content

chore(api-server): use terminalLink for route names in lambdaLoader output#1644

Merged
Tobbe merged 1 commit intocedarjs:mainfrom
lisa-assistant:lisa/api-server-terminal-link-routes
Apr 29, 2026
Merged

chore(api-server): use terminalLink for route names in lambdaLoader output#1644
Tobbe merged 1 commit intocedarjs:mainfrom
lisa-assistant:lisa/api-server-terminal-link-routes

Conversation

@lisa-assistant
Copy link
Copy Markdown
Contributor

Closes #1638

Wraps the route name logged at dev-server startup in a terminalLink hyperlink pointing to the lambda source file (file:// URL), so developers can cmd-click to open it directly in supporting terminals (iTerm2, Warp, Windows Terminal). Falls back to plain text elsewhere.

Changes:

  • packages/api-server/src/plugins/lambdaLoader.ts — import terminalLink and wrap the route name
  • packages/api-server/package.json — add termi-link: 1.1.0 dependency (matches version used across the monorepo)
  • yarn.lock — updated

🤖 Generated with Claude Code

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2026

👷 Deploy request for cedarjs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9f64784

@github-actions github-actions Bot added this to the chore milestone Apr 20, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 20, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 9f64784

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 3s View ↗
nx run-many -t build ✅ Succeeded 3m 7s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-29 07:29:14 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 20, 2026

Greptile Summary

This PR implements the TODO in lambdaLoader.ts by wrapping the route name in a terminalLink hyperlink pointing to the function's file:// URL, so developers can cmd-click to open the source file. The implementation correctly uses pathToFileURL (already imported and used on line 56) and the termi-link package version that matches the rest of the monorepo.

Confidence Score: 5/5

Safe to merge — small, well-scoped change with no logic impact beyond improved DX logging

No functional regressions: the change only affects a dev-server console.log line. pathToFileURL is used correctly (matching the existing pattern on line 56), package is added to the right dependency section, and the termi-link named-export API is consistent with every other usage in the monorepo. The implementation-docs remain accurate.

No files require special attention

Important Files Changed

Filename Overview
packages/api-server/src/plugins/lambdaLoader.ts Adds terminalLink import and wraps the route name console.log with a clickable file:// hyperlink using pathToFileURL — correct implementation
packages/api-server/package.json Adds termi-link 1.1.0 to runtime dependencies, consistent with usage in @cedarjs/internal and the monorepo-wide version
yarn.lock Lockfile updated to register termi-link 1.1.0 for the api-server package; no new package added to resolution (already resolved elsewhere)

Reviews (7): Last reviewed commit: "chore(api-server): use terminalLink for ..." | Re-trigger Greptile

@lisa-assistant lisa-assistant force-pushed the lisa/api-server-terminal-link-routes branch from e1815e3 to d774ce7 Compare April 28, 2026 10:09
Comment thread packages/api-server/src/plugins/lambdaLoader.ts Outdated
@lisa-assistant lisa-assistant force-pushed the lisa/api-server-terminal-link-routes branch from d48e613 to 067e4f9 Compare April 29, 2026 04:37
@lisa-assistant lisa-assistant force-pushed the lisa/api-server-terminal-link-routes branch from 067e4f9 to 9f64784 Compare April 29, 2026 04:39
@Tobbe Tobbe merged commit fd4fd06 into cedarjs:main Apr 29, 2026
66 of 69 checks passed
@github-actions
Copy link
Copy Markdown

The changes in this PR are now available on npm.

Try them out by running yarn cedar upgrade -t 4.0.0-canary.13863

Or try it in a new app with yarn dlx create-cedar-app@4.0.0-canary.13863

@Tobbe Tobbe modified the milestones: chore, v4.1.0 Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(api-server): use terminalLink for route names in lambdaLoader output

2 participants