Skip to content

chore(yarn): Fix build after yarn 4.14.1 upgrade#1721

Merged
Tobbe merged 2 commits intomainfrom
tobbe-fix-yarn-14-build
May 5, 2026
Merged

chore(yarn): Fix build after yarn 4.14.1 upgrade#1721
Tobbe merged 2 commits intomainfrom
tobbe-fix-yarn-14-build

Conversation

@Tobbe
Copy link
Copy Markdown
Member

@Tobbe Tobbe commented May 5, 2026

#1673 disables build scripts for packages by default. I added overrides for packages we need to build for Cedar apps, but didn't realize I needed to add them for the framework itself too. This PR addresses that oversight.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit 458588b
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/69f9f19ddab9c1000839ac98

@github-actions github-actions Bot added this to the chore milestone May 5, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 5, 2026

Greptile Summary

This PR adds a dependenciesMeta block to the root package.json to re-enable install/build scripts for native and binary packages after Yarn 4.14.1 began silently disabling them by default. It is the framework-side counterpart to the per-project fix landed in #1673.

  • Eight packages are opted back in with \"built\": true: @prisma/engines, @swc/core, better-sqlite3, cypress, esbuild, lefthook, msw, and prisma.
  • The documentation in docs/implementation-docs/2026-03-26-cedarjs-project-overview.md remains factually accurate — it refers to "Yarn 4" and "Nx build orchestration," both still correct at yarn@4.14.1.

Confidence Score: 4/5

Safe to merge; the change is minimal and targeted, with a single question about whether @playwright/test needs to be included.

The change correctly mirrors the approach used for user-facing project fixtures in #1673. The only open question is whether @playwright/test should be opted in; its absence is fine if CI invokes playwright install independently, but could silently break browser-based tests otherwise.

Only package.json changed; verify whether @playwright/test install scripts run via a separate CI step before merging.

Important Files Changed

Filename Overview
package.json Adds dependenciesMeta block re-enabling build scripts for 8 native/binary packages after Yarn 4.14.1 began disabling install scripts by default; @playwright/test is absent from the opt-in list and may need to be included depending on how CI installs browser binaries.

Reviews (1): Last reviewed commit: "yarn.lock" | Re-trigger Greptile

Comment thread package.json
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 5, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 458588b

Command Status Duration Result
nx run-many -t build ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-05 13:36:56 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 5, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 458588b

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 1s View ↗
nx run-many -t build ✅ Succeeded 5s View ↗
nx run-many -t test --minWorkers=1 --maxWorkers=4 ✅ Succeeded 1m 28s View ↗
nx run-many -t test:types ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-05 13:52:57 UTC

@Tobbe Tobbe merged commit e6aeb4c into main May 5, 2026
45 checks passed
@Tobbe Tobbe deleted the tobbe-fix-yarn-14-build branch May 5, 2026 13:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

The changes in this PR are now available on npm.

Try them out by running yarn cedar upgrade -t 5.0.0-canary.13893

Or try it in a new app with yarn dlx create-cedar-app@5.0.0-canary.13893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant