Skip to content

Commit 8fd619c

Browse files
committed
Core - Fix CPP compiler warnings
1 parent dc36d06 commit 8fd619c

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ namespace CefSharp
301301
frame->SendProcessMessage(CefProcessId::PID_BROWSER, uncaughtExceptionMessage);
302302
}
303303

304-
JavascriptRootObjectWrapper^ CefAppUnmanagedWrapper::GetJsRootObjectWrapper(int browserId, CefString frameId)
304+
JavascriptRootObjectWrapper^ CefAppUnmanagedWrapper::GetJsRootObjectWrapper(int browserId, const CefString& frameId)
305305
{
306306
auto rootObjectWrappers = _jsRootObjectWrappersByFrameId;
307307

@@ -638,15 +638,17 @@ namespace CefSharp
638638

639639
auto boundObjects = CefListValue::Create();
640640

641-
for (auto i = 0; i < javascriptObjects->Count; i++)
641+
auto i = 0;
642+
643+
for each (auto jsObject in javascriptObjects)
642644
{
643645
auto dict = CefDictionaryValue::Create();
644-
auto objectName = javascriptObjects[i]->JavascriptName;
646+
auto objectName = jsObject->JavascriptName;
645647
dict->SetString("Name", StringUtils::ToNative(objectName));
646648
dict->SetBool("IsCached", false);
647649
dict->SetBool("AlreadyBound", false);
648650

649-
boundObjects->SetDictionary(i, dict);
651+
boundObjects->SetDictionary(i++, dict);
650652
}
651653

652654
args->SetList(0, boundObjects);

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ namespace CefSharp
8585
}
8686

8787
CefBrowserWrapper^ FindBrowserWrapper(int browserId);
88-
JavascriptRootObjectWrapper^ GetJsRootObjectWrapper(int browserId, CefString frameId);
88+
JavascriptRootObjectWrapper^ GetJsRootObjectWrapper(int browserId, const CefString& frameId);
8989

9090
virtual DECL CefRefPtr<CefRenderProcessHandler> GetRenderProcessHandler() override;
9191
virtual DECL void OnBrowserCreated(CefRefPtr<CefBrowser> browser, CefRefPtr<CefDictionaryValue> extraInfo) override;

0 commit comments

Comments
 (0)