Fix #89 - consider higher than expected version a successful update

niello · niello · commit f3892dcaae6f · 2022-03-15T08:07:28.000+02:00
diff --git a/src/Application.cpp b/src/Application.cpp
@@ -308,7 +308,7 @@ void Application::checkUpdateResults()
 
     auto currentVersion = QVersionNumber::fromString(applicationVersion());
     auto savedVersion = QVersionNumber::fromString(_settings->getQSettings()->value("update/version").toString());
-    if (currentVersion.normalized() == savedVersion.normalized())
+    if (currentVersion.normalized() >= savedVersion.normalized())
     {
         // Updated but couldn't remove a tmp folder, let's try again
         if (updateResult == 30)

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ void Application::checkUpdateResults()`
`308`	`308`
`309`	`309`	`auto currentVersion = QVersionNumber::fromString(applicationVersion());`
`310`	`310`	`auto savedVersion = QVersionNumber::fromString(_settings->getQSettings()->value("update/version").toString());`
`311`		`- if (currentVersion.normalized() == savedVersion.normalized())`
	`311`	`+ if (currentVersion.normalized() >= savedVersion.normalized())`
`312`	`312`	`{`
`313`	`313`	`// Updated but couldn't remove a tmp folder, let's try again`
`314`	`314`	`if (updateResult == 30)`