Merge pull request #1054 from rayokota:fix-math-round

PiperOrigin-RevId: 916094254

Author: copybara-github

extensions/src/main/java/dev/cel/extensions/CelMathExtensions.java

@@ -874,7 +874,7 @@ private static double round(double x) {
     if (isNaN(x) || isInfinite(x)) {
       return x;
     }
-    return DoubleMath.roundToLong(x, RoundingMode.HALF_EVEN);
+    return DoubleMath.roundToLong(x, RoundingMode.HALF_UP);
   }
 
   private static Number sign(Number x) {

extensions/src/test/java/dev/cel/extensions/CelMathExtensionsTest.java

@@ -735,6 +735,13 @@ public void floor_invalidArgs_throwsException(String expr) {
   @TestParameters("{expr: 'math.round(-1.5)' , expectedResult: -2.0}")
   @TestParameters("{expr: 'math.round(-1.2)' , expectedResult: -1.0}")
   @TestParameters("{expr: 'math.round(-1.6)' , expectedResult: -2.0}")
+  // Discriminating tie cases: confirm "ties round away from zero" (HALF_UP), not
+  // banker's rounding (HALF_EVEN).  1.5/-1.5 above don't distingish the two because
+  // their nearest-even neighbor (2/-2) is also the away-from-zero neighbor.
+  @TestParameters("{expr: 'math.round(0.5)' , expectedResult: 1.0}")
+  @TestParameters("{expr: 'math.round(2.5)' , expectedResult: 3.0}")
+  @TestParameters("{expr: 'math.round(-0.5)' , expectedResult: -1.0}")
+  @TestParameters("{expr: 'math.round(-2.5)' , expectedResult: -3.0}")
   @TestParameters("{expr: 'math.round(0.0/0.0)' , expectedResult: NaN}")
   @TestParameters("{expr: 'math.round(1.0/0.0)' , expectedResult: Infinity}")
   @TestParameters("{expr: 'math.round(-1.0/0.0)' , expectedResult: -Infinity}")