Skip to content

Commit 3c5fff2

Browse files
committed
Minor improvements to CI stability
Also includes a build fix for the uncommon Tracy + OOB Check configuration
1 parent 1badf92 commit 3c5fff2

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Versioning](http://semver.org/spec/v2.0.0.html).
3939
### Fixed
4040

4141
- Host-initialized buffers will not read from user-provided memory after the last reference to the buffer has been dropped (#283)
42+
- Fix a build issue with (rare) configurations which enable both Tracy and OOB-checks (#331)
4243

4344
### Deprecated
4445

src/live_executor.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ void executor_impl::retire_async_instruction(const instruction_id iid, async_ins
492492

493493
#if CELERITY_ACCESSOR_BOUNDARY_CHECK
494494
if(async.oob_info != nullptr) {
495-
CELERITY_DETAIL_TRACY_ZONE_SCOPED_V("executor::oob_check", Red, "I{} bounds check", iid);
495+
CELERITY_DETAIL_TRACY_ZONE_SCOPED_V("executor::oob_check", executor_oob_check, "I{} bounds check", iid);
496496
const auto& oob_info = *async.oob_info;
497497
for(size_t i = 0; i < oob_info.accessors.size(); ++i) {
498498
if(const auto oob_box = oob_info.illegal_access_bounding_boxes[i].into_box(); !oob_box.empty()) {

test/test_utils.cc

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ namespace celerity::test_utils_detail {
235235

236236
const char* const expected_runtime_init_warnings_regex = "Celerity has detected that only .* logical cores are available to this process.*|"
237237
"Celerity detected more than one node \\(MPI rank\\) on this host, which is not recommended.*|"
238-
"Instrumentation for profiling with Tracy is enabled\\. Performance may be negatively impacted\\.|"
239-
"\\[executor\\] no progress for .* seconds, potentially stuck.*";
238+
"Instrumentation for profiling with Tracy is enabled\\. Performance may be negatively impacted\\.|";
240239

241240
const char* const expected_device_enumeration_warnings_regex = "Found fewer devices .* than local nodes .*, multiple nodes will use the same device.*";
242241

@@ -247,6 +246,8 @@ const char* const expected_backend_fallback_warnings_regex =
247246
const char* const expected_dry_run_executor_warnings_regex = "Encountered a \"fence\" command while \"CELERITY_DRY_RUN_NODES\" is set. The result of this "
248247
"operation will not match the expected output of an actual run.";
249248

249+
const char* const expected_executor_progress_warnings_regex = "\\[executor\\] no progress for .* s, might be stuck.*";
250+
250251
} // namespace celerity::test_utils_detail
251252

252253
namespace celerity::test_utils {
@@ -281,6 +282,11 @@ runtime_fixture::runtime_fixture() {
281282
allow_higher_level_log_messages(spdlog::level::warn, test_utils_detail::expected_runtime_init_warnings_regex);
282283
allow_higher_level_log_messages(spdlog::level::warn, test_utils_detail::expected_device_enumeration_warnings_regex);
283284
allow_higher_level_log_messages(spdlog::level::warn, test_utils_detail::expected_backend_fallback_warnings_regex);
285+
286+
// in debug builds, allow executor "stuck" warnings to avoid spurious test failures due to slow execution
287+
#if CELERITY_DETAIL_ENABLE_DEBUG
288+
allow_higher_level_log_messages(spdlog::level::warn, test_utils_detail::expected_executor_progress_warnings_regex);
289+
#endif
284290
}
285291

286292
runtime_fixture::~runtime_fixture() {

0 commit comments

Comments
 (0)