Skip to content

Avoid the breaking change in dependency cron_descriptor v2#935

Merged
auvipy merged 1 commit into
celery:mainfrom
pivotal-energy-solutions:issue-934
Aug 26, 2025
Merged

Avoid the breaking change in dependency cron_descriptor v2#935
auvipy merged 1 commit into
celery:mainfrom
pivotal-energy-solutions:issue-934

Conversation

@codecov

codecov Bot commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (66b4434) to head (ccec7ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files          32       32           
  Lines        1007     1007           
  Branches      105      105           
=======================================
  Hits          888      888           
  Misses        101      101           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss cclauss changed the title Addresses #934 Fix the breaking change in dependency cron_descriptor v2 Aug 26, 2025
@auvipy auvipy self-requested a review August 26, 2025 08:34

@cclauss cclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cron-descriptor v2 seems to break too much.

@Salamek

@cclauss cclauss changed the title Fix the breaking change in dependency cron_descriptor v2 Avoid the breaking change in dependency cron_descriptor v2 Aug 26, 2025
@auvipy auvipy merged commit 4b8799a into celery:main Aug 26, 2025
28 checks passed
@cclauss cclauss added the dependencies Pull requests that update a dependency file label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with the cron-descriptor cron_descriptor needs to be locked down as the new release changes the signature.

3 participants