chore: bump celestia-app to v9#4963
Conversation
feature/fibre was still importing github.com/celestiaorg/celestia-app/v8,
so the node could not be built against a v9 consensus binary. Bumps
every v8 reference across 40 .go files to v9 and updates go.mod to
pin celestia-app at v9.0.0-20260422212825-66060fbde7a3 (current tip
of celestia-app/main).
The v8 → v9 API surface used by celestia-node (pkg/user, x/fibre,
x/valaddr, pkg/appconsts, fibre/, etc.) is source-compatible: the
rename was mechanical, and all tagged/untagged packages build
without further code changes.
Verified against the existing bridge-over-consensus test suite with
-tags fibre:
- blob tests pass (Subscribe + GetByHeight paths)
- api/client tests pass:
- TestSubmission drives bridge + consensus via core gRPC
- TestFibreEscrow drives bridge + consensus + fibre module (deposit,
query, withdraw, pending withdrawals) end-to-end
No new tests are added; existing coverage is enough to confirm that
the bridge node can talk to a v9 consensus endpoint.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Hardcoded "version 8" in validate test not updated after celestia-app v9 bump
The test at header/headertest/validate_test.go:56-58 hardcodes that app version 9 should be rejected with error string "supports up to version 8". In the previous celestia-app bump (v7→v8, commit b74f135a), this test was updated to match the new appconsts.Version. This PR bumps to celestia-app/v9 but does not update the test expectations. If appconsts.Version was incremented to 9 (following the established pattern), version 9 would now be valid and header.Validate() would return nil instead of an error, causing this test case to fail. The production code at header/header.go:116 uses the constant dynamically and is correct regardless — this is an incomplete test migration.
(Refers to lines 56-58)
Prompt for agents
The test in header/headertest/validate_test.go hardcodes that app version 9 should fail validation with error 'supports up to version 8'. If appconsts.Version in celestia-app/v9 has been bumped to 9, this test is now wrong: version 9 would be valid and the test expects an error that won't come. The fix would be to: (1) add version 9 as a valid test case (wantErr: ''), (2) change the invalid test case to version 10 with error string 'supports up to version 9', or better yet, use appconsts.Version dynamically as core/header_test.go:TestBadAppVersion already does. Check the actual value of appconsts.Version in the v9 dependency to confirm.
Was this helpful? React with 👍 or 👎 to provide feedback.
2 participants
Summary
`feature/fibre` was still importing `github.com/celestiaorg/celestia-app/v8`, which made the node unable to run against a v9-built consensus binary. This PR bumps every v8 reference across 40 .go files to v9 and updates `go.mod` to pin celestia-app at `v9.0.0-20260422212825-66060fbde7a3` (current tip of `celestia-app/main`).
Scope
Verified
Existing bridge-over-consensus coverage passes with `-tags fibre`:
Per the request in this change: no new tests added; the existing suite is sufficient to confirm the bridge can talk to a v9 consensus endpoint.
🤖 Generated with Claude Code