bump: bump celestia app to v9#4964
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔴 Hardcoded test expectations not updated after celestia-app major version bump
The test TestValidate in header/headertest/validate_test.go hardcodes that app version 9 should fail validation with "has version 9, this node supports up to version 8". The validation logic at header/header.go:116 checks eh.Version.App > appconsts.Version. If appconsts.Version changed from 8 to 9 with the celestia-app/v9 upgrade (as is typical — the Go module major version tracks the app protocol version in celestia), then version 9 is now valid and the test will fail: the test expects an error but Validate() returns nil. By contrast, core/header_test.go:63 uses appconsts.Version + 1 dynamically and would auto-adapt. The fix should add a test case for version 10 as the new failing version, make version 9 pass, and update the error string to reference version 9.
(Refers to lines 56-59)
Prompt for agents
In header/headertest/validate_test.go, the TestValidate function hardcodes that app version 9 should fail with error 'supports up to version 8'. After the celestia-app/v8 to v9 upgrade, if appconsts.Version is now 9, then: (1) the test case for version 9 should expect no error (wantErr: ''), (2) a new test case for version 10 should be added that expects the failure with error message 'has version 10, this node supports up to version 9'. Alternatively, make the test dynamic like core/header_test.go:61-67 does, using appconsts.Version+1 instead of hardcoded values.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Uh oh!
There was an error while loading. Please reload this page.