Skip to content

fix: close stats file on write error #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Radovenchyk wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −4
Open

fix: close stats file on write error #4967

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f898ea
fix: close stats file on write error
Radovenchyk Apr 24, 2026
a28f071
fix: propagate Close() error in dumpStat using named return
Radovenchyk May 1, 2026
c18ffe3
Merge branch 'main' into patch-2
ninabarbakadze May 4, 2026
0933f6f
Fix: Add Missing Closing Brace in dumpStat Function
Radovenchyk May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions libs/edssser/edssser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,16 @@ func (ss *EDSsser) dumpStat(stats Stats) (err error) {
return err
}

defer func() {
err = errors.Join(err, ss.statsFile.Close())
}()

_, err = ss.statsFile.Write([]byte(stats.String()))
if err != nil {
return err
return err
}

return ss.statsFile.Close()
}
return nil
}

type Stats struct {
TotalWritten int
Expand Down