prebuild v2.12.0-pb / Node 18 / all platforms

Author: zbjornson

.github/workflows/prebuild.yaml

@@ -49,8 +49,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [8, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]
-        canvas_tag: ["v2.11.2"] # e.g. "v2.6.1"
+        node: [18]
+        canvas_tag: ["v2.12.0-pb"] # e.g. "v2.6.1"
     name: ${{ matrix.canvas_tag }}, Node.js ${{ matrix.node }}, Linux
     runs-on: ubuntu-latest
     container:
@@ -81,9 +81,8 @@ jobs:
           set -ex
           mkdir -p prebuild
           cp -rfv ./prebuild-branch/prebuild/* ./prebuild/
-          npm install -g node-gyp@6
+          npm install -g node-gyp
           npm install --ignore-scripts
-          . prebuild/Linux/preinstall.sh
           cp prebuild/Linux/binding.gyp binding.gyp
           node-gyp rebuild -j 2
           . prebuild/Linux/bundle.sh
@@ -142,10 +141,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [13, 14, 15, 16, 17, 18, 19]
-        canvas_tag: ["v2.11.2"] # e.g. "v2.6.1"
+        node: [18]
+        canvas_tag: ["v2.12.0-pb"] # e.g. "v2.6.1"
     name: ${{ matrix.canvas_tag}}, Node.js ${{ matrix.node }}, macOS
-    runs-on: macos-latest
+    runs-on: macos-15
     env:
       CANVAS_VERSION_TO_BUILD: ${{ matrix.canvas_tag }}
     steps:
@@ -177,6 +176,12 @@ jobs:
           brew uninstall --force --ignore-dependencies cairo pango librsvg giflib harfbuzz
           npm test
 
+      - name: Sign the executable
+        run: |
+          for file in $(ls build/Release);
+          do codesign --deep --force --sign - build/Release/$file;
+          done;
+
       - name: Make bundle
         id: make_bundle
         run: . prebuild/tarball.sh
@@ -215,10 +220,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [13, 14, 15, 16, 17, 18, 19]
-        canvas_tag: ["v2.11.2"] # e.g. "v2.6.1"
+        node: [18]
+        canvas_tag: ["v2.12.0-pb"] # e.g. "v2.6.1"
     name: ${{ matrix.canvas_tag}}, Node.js ${{ matrix.node }}, Windows
-    runs-on: windows-2019
+    runs-on: windows-2025
     env:
       CANVAS_VERSION_TO_BUILD: ${{ matrix.canvas_tag }}
     steps:
@@ -227,6 +232,7 @@ jobs:
       # https://github.com/msys2/setup-msys2#setup-msys2
       # https://github.com/actions/virtual-environments/pull/632
       - uses: msys2/setup-msys2@v2
+        id: msys2
         with:
           msystem: UCRT64
           update: true
@@ -245,9 +251,11 @@ jobs:
 
       - name: Build
         run: |
+          winget install --accept-source-agreements --id=Microsoft.VCRedist.2010.x64 -e
+          echo "MSYS2 LOCATION: ${{steps.msys2.outputs.msys2-location}}"
           git checkout ${{ matrix.canvas_tag }}
           git checkout $env:GITHUB_SHA -- prebuild/
-          npm install -g node-gyp@8
+          npm install -g node-gyp
           npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"}
           npm install --ignore-scripts
           msys2 -c ". prebuild/Windows/preinstall.sh"
@@ -261,6 +269,8 @@ jobs:
       - name: Bundle pt 2
         shell: msys2 {0}
         run: |
+          # removes object files and debug
+          . prebuild/Windows/bundle.sh
           ./depends.exe -c -oc depends.csv build\\Release\\canvas.node || true
           [ -f depends.csv ] || { echo "error invoking depends.exe"; exit 1; }
 

prebuild/Linux/binding.gyp

@@ -22,8 +22,7 @@
       ],
       'defines': [
         'HAVE_GIF',
-        'HAVE_JPEG',
-        'HAVE_RSVG'
+        'HAVE_JPEG'
       ],
       'libraries': [
         '<!@(pkg-config pixman-1 --libs)',

prebuild/Linux/bundle.sh

@@ -1,11 +1,27 @@
 set -ex
 
-copies=$(lddtree.sh -l build/Release/canvas.node | sed -r -e '/^\/lib/d' -e '/canvas.node$/d');
+# ChatGPT gave me this. I'm doing the lazy thing instead of properly updating
+# the dockerfile because I'm almost done with a zig cross build
+sed -i '
+  s|deb.debian.org/debian|archive.debian.org/debian|g;
+  s|security.debian.org/debian-security|archive.debian.org/debian-security|g;
+' /etc/apt/sources.list
+apt-get -o Acquire::Check-Valid-Until=false update
+# end ChatGPT
 
-apt install -y patchelf
+apt-get update
+apt install -y patchelf pax-utils
+
+copies=$(lddtree -l build/Release/canvas.node | sed -r -e '/^\/lib/d' -e '/canvas.node$/d');
+
+# remove the big artifacts we will not use.
+rm -r build/Release/.deps
+rm -r build/Release/obj.target
 
 for so in $copies; do
   cp $so build/Release
   # Set the run_path for all dependencies.
   patchelf --set-rpath '$ORIGIN' build/Release/$(basename $so)
 done;
+
+find "./build/Release" -type f -name "*.so*" -exec strip --strip-unneeded {} \;

prebuild/Linux/preinstall.sh

@@ -23,7 +23,6 @@
       'defines': [
         'HAVE_GIF',
         'HAVE_JPEG',
-        'HAVE_RSVG',
         'HAVE_BOOLEAN', # or jmorecfg.h tries to define it
         '_USE_MATH_DEFINES', # for M_PI
         'NOMINMAX' # allow std::min/max to work
@@ -38,8 +37,7 @@
         'D:/a/_temp/msys64/ucrt64/lib/libglib-2.0-0.lib',
         'D:/a/_temp/msys64/ucrt64/lib/libturbojpeg.lib',
         'D:/a/_temp/msys64/ucrt64/lib/libgif-7.lib',
-        'D:/a/_temp/msys64/ucrt64/lib/libfreetype-6.lib',
-        'D:/a/_temp/msys64/ucrt64/lib/librsvg-2-2.lib'
+        'D:/a/_temp/msys64/ucrt64/lib/libfreetype-6.lib'
       ],
       'include_dirs': [
         '<!(node -e "require(\'nan\')")',
@@ -53,7 +51,6 @@
         'D:/a/_temp/msys64/ucrt64/include/pixman-1',
         'D:/a/_temp/msys64/ucrt64/include/freetype2',
         'D:/a/_temp/msys64/ucrt64/include/fontconfig',
-        'D:/a/_temp/msys64/ucrt64/include/librsvg-2.0',
         'D:/a/_temp/msys64/ucrt64/include/gdk-pixbuf-2.0',
         'D:/a/_temp/msys64/ucrt64/include/libgsf-1' # NEW
       ],

prebuild/Windows/binding.gyp

@@ -0,0 +1,8 @@
+# remove the big artifacts we will not use.
+# on windows this is >45mbytes.
+rm -r build/Release/obj
+rm -r build/Release/canvas.exp
+rm -r build/Release/canvas.iobj
+rm -r build/Release/canvas.ipdb
+rm -r build/Release/canvas.lib
+rm -r build/Release/canvas.pdb

prebuild/Windows/bundle.sh

@@ -15,7 +15,6 @@ pacman --noconfirm -S \
   ucrt64/mingw-w64-ucrt-x86_64-giflib \
   ucrt64/mingw-w64-ucrt-x86_64-freetype \
   ucrt64/mingw-w64-ucrt-x86_64-fontconfig \
-  ucrt64/mingw-w64-ucrt-x86_64-librsvg \
   ucrt64/mingw-w64-ucrt-x86_64-libxml2 \
   ucrt64/mingw-w64-ucrt-x86_64-libgsf
 

prebuild/Windows/preinstall.sh

@@ -22,8 +22,7 @@
       ],
       'defines': [
         'HAVE_GIF',
-        'HAVE_JPEG',
-        'HAVE_RSVG'
+        'HAVE_JPEG'
       ],
       'libraries': [
         '<!@(pkg-config pixman-1 --libs)',
@@ -41,7 +40,8 @@
         '<!@(pkg-config libpng --cflags-only-I | sed s/-I//g)',
         '<!@(pkg-config pangocairo --cflags-only-I | sed s/-I//g)',
         '<!@(pkg-config freetype2 --cflags-only-I | sed s/-I//g)',
-        '<!@(pkg-config librsvg-2.0 --cflags-only-I | sed s/-I//g)'
+        '<!@(pkg-config librsvg-2.0 --cflags-only-I | sed s/-I//g)',
+        '/opt/homebrew/include'
       ],
       'xcode_settings': {
         'GCC_ENABLE_CPP_EXCEPTIONS': 'YES'

prebuild/macOS/binding.gyp

@@ -1,4 +1,8 @@
 build=build/Release
 
+# remove the big artifacts we will not use.
+rm -r build/Release/.deps
+rm -r build/Release/obj.target
+
 ~/Library/Python/*/bin/macpack build/Release/canvas.node -d .
 

prebuild/macOS/bundle.sh

@@ -8,6 +8,8 @@ rm -f /usr/local/bin/pydoc3 || :
 rm -f /usr/local/bin/python3 || :
 rm -f /usr/local/bin/python3-config || :
 
-brew install --force pkg-config cairo pango librsvg giflib
+# two or more of these packages have python3 as a dependency, and --overwrite
+# doesn't work to make them ignore conflicts. For now just ignore errors, yolo.
+brew install --force pkg-config cairo pango librsvg giflib || :
 
-pip3 install --user macpack
+pip3 install --user --break-system-packages macpack