Skip to content

Commit 6cafc0f

Browse files
kuviakuvia
committed
fix all existing tests
1 parent 574d26c commit 6cafc0f

23 files changed

Lines changed: 55 additions & 56 deletions

‎src/core/utils/file-service.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ export class FileService {
9898
const files = fs.readdirSync(targetDir);
9999
for (const file of files) {
100100
const filePath = path.join(targetDir, file);
101-
const fileStats = fs.statSync(filePath);
102-
if (fileStats.isDirectory()) {
101+
if (fs.statSync(filePath)?.isDirectory()) {
103102
fs.chmodSync(filePath, 0o700);
104103
this.restrictFilePermissions(filePath);
105104
} else {

‎tests/commands/action-flows/analyze-action-flows.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe("Analyze action-flows", () => {
6464
expect(loggingTestTransport.logMessages[0].message).toContain(FileService.fileDownloadedMessage);
6565
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
6666

67-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(mockAnalyzeResponse, null, 4), { encoding: "utf-8" });
67+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(mockAnalyzeResponse, null, 4), { encoding: "utf-8", mode: "0600" });
6868
expect(mockedAxiosInstance.get).toHaveBeenCalledWith(`https://myTeam.celonis.cloud/ems-automation/api/root/${packageId}/export/assets/analyze`, expect.anything());
6969
});
7070
});

‎tests/commands/action-flows/import-action-flows.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ describe("Import action-flows", () => {
5050
expect(loggingTestTransport.logMessages[0].message).toContain(FileService.fileDownloadedMessage);
5151
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
5252

53-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(mockImportResponse, null, 4), { encoding: "utf-8" });
53+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(mockImportResponse, null, 4), { encoding: "utf-8", mode: "0600" });
5454
expect(mockedAxiosInstance.post).toHaveBeenCalledWith(`https://myTeam.celonis.cloud/ems-automation/api/root/${packageId}/import/assets`, expect.anything(), expect.anything());
5555
});
5656
});

‎tests/commands/configuration-management/config-diff.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ describe("Config diff", () => {
138138

139139
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
140140

141-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
141+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
142142
const exportedPackageDiffTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageDiffTransport[];
143143
expect(exportedPackageDiffTransport.length).toBe(1);
144144

@@ -169,7 +169,7 @@ describe("Config diff", () => {
169169

170170
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
171171

172-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
172+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
173173
const exportedPackageDiffTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageDiffTransport[];
174174
expect(exportedPackageDiffTransport.length).toBe(1);
175175

‎tests/commands/configuration-management/config-import.spec.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe("Config import", () => {
6565
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, overwrite, null);
6666

6767
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
68-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
68+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
6969
})
7070

7171
it.each([
@@ -98,7 +98,7 @@ describe("Config import", () => {
9898
await new ConfigCommandService(testContext).batchImportPackages(null, null, overwrite, branchName);
9999

100100
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
101-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
101+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
102102
})
103103

104104
it.each([
@@ -137,7 +137,7 @@ describe("Config import", () => {
137137
await new ConfigCommandService(testContext).batchImportPackages(null, null, overwrite, branchName);
138138

139139
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
140-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
140+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
141141
})
142142

143143
it("Should batch import configs & map space ID as specified in manifest file for Studio Packages", async () => {
@@ -181,7 +181,7 @@ describe("Config import", () => {
181181
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, true, null);
182182

183183
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
184-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
184+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
185185
})
186186

187187
it("Should fail to map space ID as the space id specified in manifest file cannot be found", async () => {
@@ -252,7 +252,7 @@ describe("Config import", () => {
252252

253253
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, true, null);
254254
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
255-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
255+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
256256
expect(mockedAxiosInstance.put).toHaveBeenCalledWith("https://myTeam.celonis.cloud/package-manager/api/packages/node-id/move/spaceId", expect.anything(), expect.anything());
257257
})
258258

@@ -290,7 +290,7 @@ describe("Config import", () => {
290290
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, true, null);
291291

292292
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
293-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
293+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
294294
expect(mockedAxiosInstance.put).not.toHaveBeenCalledWith("https://myTeam.celonis.cloud/package-manager/api/spaces", expect.anything(), expect.anything());
295295
})
296296

@@ -337,7 +337,7 @@ describe("Config import", () => {
337337
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, true, null);
338338

339339
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
340-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
340+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
341341
expect(mockedAxiosInstance.put).not.toHaveBeenCalledWith("https://myTeam.celonis.cloud/package-manager/api/spaces", expect.anything(), expect.anything());
342342
})
343343

@@ -416,7 +416,7 @@ describe("Config import", () => {
416416
await new ConfigCommandService(testContext).batchImportPackages("./export_file.zip", null, true, null);
417417

418418
const expectedFileName = loggingTestTransport.logMessages[0].message.split(LOG_MESSAGE)[1];
419-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8"});
419+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(importResponse), {encoding: "utf-8", mode: "0600"});
420420

421421
expect(mockedPostRequestBodyByUrl.get(assignVariablesUrl)).toEqual(JSON.stringify([variableAssignment]));
422422
})

‎tests/commands/configuration-management/config-list-variables.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe("Config listVariables", () => {
132132
expect(loggingTestTransport.logMessages[0].message).toContain(FileService.fileDownloadedMessage);
133133

134134
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
135-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(fixedVariableManifests), {encoding: "utf-8"});
135+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(fixedVariableManifests), {encoding: "utf-8", mode: "0600"});
136136

137137
const variableExportRequest = parse(mockedPostRequestBodyByUrl.get("https://myTeam.celonis.cloud/package-manager/api/core/packages/export/batch/variables-with-assignments"));
138138
expect(variableExportRequest).toEqual(packageKeyAndVersionPairs);
@@ -163,7 +163,7 @@ describe("Config listVariables", () => {
163163
expect(loggingTestTransport.logMessages[0].message).toContain(FileService.fileDownloadedMessage);
164164

165165
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
166-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(fixedVariableManifests), {encoding: "utf-8"});
166+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), JSON.stringify(fixedVariableManifests), {encoding: "utf-8", mode: "0600"});
167167

168168
const variableExportRequest = parse(mockedPostRequestBodyByUrl.get("https://myTeam.celonis.cloud/package-manager/api/core/packages/export/batch/variables-with-assignments"));
169169
expect(variableExportRequest).toEqual(packageKeyAndVersionPairs);
@@ -226,7 +226,7 @@ describe("Config listVariables", () => {
226226
expect(mockWriteFileSync).toHaveBeenCalledWith(
227227
path.resolve(process.cwd(), expectedFileName),
228228
JSON.stringify(pkgAOnlyResponse),
229-
{encoding: "utf-8"}
229+
{encoding: "utf-8", mode: "0600"}
230230
);
231231

232232
const postBody = parse<string[]>(mockedPostRequestBodyByUrl.get(url));

‎tests/commands/configuration-management/config-list.spec.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe("Config list", () => {
5353

5454
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
5555

56-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
56+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
5757

5858
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
5959
expect(exportedTransports.length).toBe(2);
@@ -99,7 +99,7 @@ describe("Config list", () => {
9999

100100
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
101101

102-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
102+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
103103

104104
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
105105
expect(exportedTransports.length).toBe(2);
@@ -124,7 +124,7 @@ describe("Config list", () => {
124124

125125
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
126126

127-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
127+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
128128

129129
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
130130
expect(exportedTransports.length).toBe(2);
@@ -170,7 +170,7 @@ describe("Config list", () => {
170170

171171
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
172172

173-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
173+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
174174

175175
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
176176
expect(exportedTransports.length).toBe(2);
@@ -208,7 +208,7 @@ describe("Config list", () => {
208208

209209
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
210210

211-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
211+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
212212

213213
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
214214
expect(exportedTransports.length).toBe(2);
@@ -263,7 +263,7 @@ describe("Config list", () => {
263263

264264
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
265265

266-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
266+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
267267

268268
const exportedTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageExportTransport[];
269269
expect(exportedTransports.length).toBe(2);

‎tests/commands/configuration-management/config-metadata-export.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe("Config metadata export", () => {
5353

5454
const expectedFileName = loggingTestTransport.logMessages[0].message.split(FileService.fileDownloadedMessage)[1];
5555

56-
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8"});
56+
expect(mockWriteFileSync).toHaveBeenCalledWith(path.resolve(process.cwd(), expectedFileName), expect.any(String), {encoding: "utf-8", mode: "0600"});
5757
const exportedPackagesMetadataTransports = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as PackageMetadataExportTransport[];
5858
expect(exportedPackagesMetadataTransports.length).toBe(2);
5959

‎tests/commands/configuration-management/config-node-dependency.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe("Node Dependencies", () => {
5757
expect(mockWriteFileSync).toHaveBeenCalledWith(
5858
path.resolve(process.cwd(), expectedFileName),
5959
expect.any(String),
60-
{ encoding: "utf-8" }
60+
{ encoding: "utf-8", mode: "0600" }
6161
);
6262

6363
const dependenciesTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeDependencyTransport[];
@@ -94,7 +94,7 @@ describe("Node Dependencies", () => {
9494
expect(mockWriteFileSync).toHaveBeenCalledWith(
9595
path.resolve(process.cwd(), expectedFileName),
9696
expect.any(String),
97-
{ encoding: "utf-8" }
97+
{ encoding: "utf-8", mode: "0600" }
9898
);
9999

100100
const dependenciesTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeDependencyTransport[];
@@ -152,7 +152,7 @@ describe("Node Dependencies", () => {
152152
expect(mockWriteFileSync).toHaveBeenCalledWith(
153153
path.resolve(process.cwd(), expectedFileName),
154154
expect.any(String),
155-
{ encoding: "utf-8" }
155+
{ encoding: "utf-8", mode: "0600" }
156156
);
157157

158158
const dependenciesTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeDependencyTransport[];
@@ -189,7 +189,7 @@ describe("Node Dependencies", () => {
189189
expect(mockWriteFileSync).toHaveBeenCalledWith(
190190
path.resolve(process.cwd(), expectedFileName),
191191
expect.any(String),
192-
{ encoding: "utf-8" }
192+
{ encoding: "utf-8", mode: "0600" }
193193
);
194194

195195
const dependenciesTransport = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeDependencyTransport[];

‎tests/commands/configuration-management/config-node-diff.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe("Node diff", () => {
7878
expect(mockWriteFileSync).toHaveBeenCalledWith(
7979
path.resolve(process.cwd(), expectedFileName),
8080
expect.any(String),
81-
{ encoding: "utf-8" }
81+
{ encoding: "utf-8", mode: "0600" }
8282
);
8383

8484
const savedDiff = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeConfigurationDiffTransport;
@@ -223,7 +223,7 @@ describe("Node diff", () => {
223223
expect(mockWriteFileSync).toHaveBeenCalledWith(
224224
path.resolve(process.cwd(), expectedFileName),
225225
expect.any(String),
226-
{ encoding: "utf-8" }
226+
{ encoding: "utf-8", mode: "0600" }
227227
);
228228

229229
const savedDiff = JSON.parse(mockWriteFileSync.mock.calls[0][1]) as NodeConfigurationDiffTransport;

0 commit comments

Comments
 (0)