cmake: converge to generic find_package(Avendish) + avnd_addon_* setup#4
Merged
Conversation
…ore addon or standalone)
- builds.yaml calls ossia/actions/.github/workflows/avnd-addon.yml with all 11 backend toggles ON (the template's avnd_addon_object uses CATEGORY all, so every backend is expected). The new workflow brings per-backend SDK fetches (CLAP/VST3/PD/Max/TD/pybind11/emsdk) inline, so no special template-only composite is needed. - portability.yml calls avnd-portability.yml — desktop GCC/Clang/MSVC/ mingw matrix + FreeBSD + WASM + Android + iOS + ESP32 + RP2040 (the embedded lanes auto-skip without examples/*.ino, so they're silent for this template). - Drops build_cmake.yml + build_vs2026.yml (replaced + the new flow ships its own continuous-release job). builds.yaml currently pins ossia/actions to the @drop-ossia-sdk-dep branch while the corresponding actions PR is in review — flip to @master once it lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
…ixes Pins to c3f4b7c (avendish main HEAD) which includes: - option(AVND_ENABLE_<BACKEND>) flags for selective CI builds - corrected per-backend output naming (clap/vintage/python/vst3/standalone) - godot .framework BUNDLE on macOS + matching .gdextension paths Lets the new ossia/actions packagers find artifacts at the expected names (e.g. clap composite now finds <name>.clap instead of failing on <name>.clap.so). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- standalone: false — avendish's standalone backend is incomplete and needs a GUI toolkit (Qt / GLEW+glfw) not provisioned in CI. - Re-pin avendish to the fix-wasm-embind commit (celtera/avendish#105) so the wasm lane links embind via -lembind. Bump back to a main SHA once that PR merges. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Point at @drop-ossia-sdk-dep to pick up the fixed avnd-portability.yml (real SDK-free build instead of placeholder flags). - Add migrate-avnd-addon to the push trigger so the workflow actually runs while in review (GitHub doesn't fire pull_request for a workflow added in the same PR). Drop both feature-branch refs once ossia/actions#9 lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
iOS isn't a meaningful target for an audio-processing avendish addon, and the lane failed on Xcode multi-config intermediate-path plumbing (the .a lands in a different config dir than the link step expects) rather than any real portability issue. The remaining 20 lanes cover the surface that matters. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avendish#105 and ossia/actions#9 are merged, so: - re-pin avendish to main (7f7dac9, the embind link-order fix) - point both workflows at ossia/actions ...@master - drop the testing-only migrate-avnd-addon push trigger and the workflow_dispatch/pull_request types scaffolding Final shipping config for the template. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # .github/workflows/build_cmake.yml # .github/workflows/build_vs2026.yml
Moves off the temporary feature-branch SHA to avendish main, which now includes the wasm enum-control fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the template to the unified Avendish addon CMake (celtera/avendish#97):
dependencies.cmake+add_library+avnd_make_all→find_package(Avendish)(host-aware, with a FetchContent fallback) +avnd_addon_init/object/finalize.avnd_make_godot.The same
CMakeLists.txtnow builds this as an ossia/score add-on (ossia back-end only) or standalone (all the avnd_make_all back-ends).CATEGORY allselects every back-end family. Validated: configures + builds against avendish main.