cmake: allow using system-installed readerwriterqueue#157
Merged
jcelerier merged 1 commit intoceltera:masterfrom Jul 3, 2025
Merged
cmake: allow using system-installed readerwriterqueue#157jcelerier merged 1 commit intoceltera:masterfrom
jcelerier merged 1 commit intoceltera:masterfrom
Conversation
Member
|
Sorry, had missed this PR! reviewing |
Member
|
yes, looks good :) thanks! |
jcelerier
force-pushed
the
system-readerwriterqueue
branch
from
74fd95d to
1922943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readerwriterqueuecan be installed into system directories, and a number of distributions already package it. Where possible, use the system-provided copy rather than requiring it to be downloaded viaFetchContent.Currently the default behavior provided by this PR is to use the system-provided copy if available; if preferred, this can also be inverted to prefer the
FetchContentand only rely on the system version via an explicit option.The objective of this PR is to allow downstream packagers to rely on their own system-installed copies of dependencies where possible rather than have them be downloaded at compile time. (I'd like to do the same for
ni-midi2, but the build system forni-midi2does not yet facilitate installing it into system directories.)If this change is not accepted, downstream packagers can still point
FetchContentto a system-provided copy ofreaderwriterqueue, e.g.-DFETCHCONTENT_SOURCE_DIR_READERWRITERQUEUE:PATH=/usr/lib/cmake/readerwriterqueue.