dnsx/cacher,intra/common,dns53/ipmapper: m comments

Author: ignoramous

intra/common.go

@@ -192,7 +192,7 @@ func (h *baseHandler) onFlow(localaddr, target netip.AddrPort) (fm *Mark, undidA
 		} // else: either no known transport or preflow failed
 
 		if !hasPre || !hasNewIPs {
-			log.E("com: %s: onFlow: alg, but no preflow? %t, ips? %t for %v; uid: %s; block!",
+			log.E("com: %s: onFlow: alg, preflow? %t, ips? %t for %v; uid: %s; block!",
 				h.proto, hasPre, hasNewIPs, doms, pre)
 			// either optionsBase (BlockModeNone) or optionsBlock
 			return fm, undidAlg, "", ""

intra/dns53/ipmapper.go

@@ -190,8 +190,8 @@ func (m *ipmapper) queryIP2(_ context.Context, network, host, uid string, tid ..
 	ips = append(ips, ip4...)
 	ips = append(ips, ip6...)
 
-	log.D("ipmapper: host %s => ips (out: %v / in: %v+%v); tids: %s+%s; err4: %v, err6: %v",
-		host, ips, r4, r6, tid4, tid6, lerr4, lerr6)
+	log.D("ipmapper: host %s => ips (out: %v / in: %d+%d); tids: %s+%s; err4: %v, err6: %v",
+		host, ips, len(r4), len(r6), tid4, tid6, lerr4, lerr6)
 	return ips, nil
 }
 

intra/dnsx/cacher.go

@@ -265,12 +265,12 @@ func (cb *cache) put(key string, ans *dns.Msg, s *x.DNSSummary) (ok bool) {
 		log.W("cache: put: cache overflow %d > %d", len(cb.c), cb.size)
 	}
 
-	// ansttl is 0 for synthesized "block" answers (see xdns.BlockTTL)
+	// 1. ansttl is 0 for synthesized "block" answers (see xdns.BlockTTL)
+	// 2. for most empty ans (like qtype:65), ansttl is 0
 	ansttl := time.Duration(xdns.RTtl(ans)) * time.Second
 	if ansttl < cb.ttl {
 		ansttl = cb.ttl
-	} else {
-		// bump up a bit longer than the ttl
+	} else { // bump up a bit longer than the ttl
 		ansttl = ansttl + cb.halflife
 	}
 	exp := time.Now().Add(ansttl)