Skip to content

Commit 6b7e548

Browse files
committed
netstack/icmp: m debug log header
1 parent c3d8279 commit 6b7e548

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

intra/netstack/icmpecho.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ func (r *icmpResponder) handle(b buffer.Buffer) (handled bool) {
9393
// feeding them back into netstack.
9494
if parsed.IPProto != wire.ICMPv4 && parsed.IPProto != wire.ICMPv6 {
9595
if settings.Debug {
96-
log.VV("icmp: responder: unsupported proto: %d / echo: %t; content: %x",
97-
parsed.IPProto, parsed.IsEchoRequest(), parsed.Buffer())
96+
log.VV("icmp: responder: unsupported proto: %d / echo: %t; h: %s; content: %x",
97+
parsed.IPProto, parsed.IsEchoRequest(), parsed.ICMPHeaderString(), parsed.Buffer())
9898
}
9999
wire.Pool.Put(parsed)
100100
return
@@ -105,7 +105,7 @@ func (r *icmpResponder) handle(b buffer.Buffer) (handled bool) {
105105
dst := parsed.Dst
106106
has := parsed.HasTransportData()
107107

108-
logwv(!has)("icmp: responder: request ipv%d; %s => %s; ok? %t", parsed.IPVersion, src, dst, has)
108+
logwv(!has)("icmp: responder: request ipv%d; %s => %s; h: %s; ok? %t", parsed.IPVersion, src, dst, parsed.ICMPHeaderString(), has)
109109

110110
if !has {
111111
wire.Pool.Put(parsed)
@@ -122,8 +122,8 @@ func (r *icmpResponder) handle(b buffer.Buffer) (handled bool) {
122122

123123
if !parsed.IsEchoRequest() {
124124
if settings.Debug {
125-
log.VV("icmp: responder: not echo request ipv%d; %s => %s; type: %d; %x",
126-
parsed.IPVersion, src, dst, parsed.IPProto, parsed.Buffer())
125+
log.VV("icmp: responder: not echo request ipv%d; %s => %s; h: %s; %x",
126+
parsed.IPVersion, src, dst, parsed.ICMPHeaderString(), parsed.Buffer())
127127
}
128128
wire.Pool.Put(parsed)
129129
return

0 commit comments

Comments
 (0)