ipn/proxy: allow 10s proxy cooldown time before onNotOK

Author: ignoramous

intra/ipn/proxies.go

@@ -143,6 +143,7 @@ const (
 	responseHeaderTimeout = 60 * time.Second
 	tzzTimeout            = 2 * time.Minute  // time between new connections before proxies transition to idle
 	lastOKThreshold       = 10 * time.Minute // time between last OK and now before pinging & un-pinning
+	ageThreshold          = 10 * time.Second // time for proxy to start up
 	pintimeout            = 10 * time.Minute // time to keep a pin
 	alwaysPin             = true             // always pin to a proxy no matter the errors
 	maxFailingPinTrackTTl = 30 * time.Second // max period to track a failing to-be-pinned proxy

intra/ipn/proxy.go

@@ -681,13 +681,16 @@ func healthy(p Proxy) error {
 
 	stat := p.Router().Stat()
 	now := now()
+	age := now - stat.Since
+
+	oldEnough := age > ageThreshold.Milliseconds()
 	lastOK := stat.LastOK
 	lastOKNeverOK := lastOK <= 0
 	lastOKBeyondThres := now-lastOK > lastOKThreshold.Milliseconds()
-	if lastOKNeverOK || lastOKBeyondThres {
+	if (oldEnough && lastOKNeverOK) || lastOKBeyondThres {
 		core.Gx("healthy.TNT."+pid, func() { p.onNotOK() }) // not ok for too long
-		return fmt.Errorf("proxy: %s not ok; lastOK: zz? %t / thres? %t",
-			pid, lastOKNeverOK, lastOKBeyondThres)
+		return fmt.Errorf("proxy: %s not ok; age: %s / lastOKNeverOK? %t / lastOKBeyondThres? %t",
+			pid, core.FmtMillis(age), lastOKNeverOK, lastOKBeyondThres)
 	} else if now-lastOK > tzzTimeout.Milliseconds() {
 		core.Gx("healthy.TZZ."+pid, func() { p.Ping() })
 	} else if p.Status() != TOK {