netstack/forwarders: fatal on test

ignoramous · ignoramous · commit 9aede95e303a · 2026-01-16T20:01:00.000+05:30
diff --git a/intra/netstack/forwarders.go b/intra/netstack/forwarders.go
@@ -161,7 +161,6 @@ func (p *processor) start(wg *sync.WaitGroup) {
 // deliverPackets delivers packets to the endpoint; thread-safe.
 func (p *processor) deliverPackets() {
 	testpanic := settings.PanicAtRandom.Load() && rand10pc()
-	testfatal := settings.FatalAtRandom.Load() && rand10pc()
 	if testpanic {
 		defer core.Recover(core.DontExit, "ns.forwarder.deliverPackets")
 	}
@@ -183,8 +182,12 @@ func (p *processor) deliverPackets() {
 	if testpanic {
 		panic("ns: tun: forwarder: deliverPackets rand10pc")
 	}
-	if testfatal {
+	if settings.FatalAtRandom.Load() {
 		core.RuntimeWtf("ns: tun: forwarder: test fatal")
+		if rand10pc() {
+			var mu sync.Mutex
+			mu.Unlock() // ka-boom
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,6 @@ func (p processor) start(wg sync.WaitGroup) {`
`161`	`161`	`// deliverPackets delivers packets to the endpoint; thread-safe.`
`162`	`162`	`func (p *processor) deliverPackets() {`
`163`	`163`	`testpanic := settings.PanicAtRandom.Load() && rand10pc()`
`164`		`- testfatal := settings.FatalAtRandom.Load() && rand10pc()`
`165`	`164`	`if testpanic {`
`166`	`165`	`defer core.Recover(core.DontExit, "ns.forwarder.deliverPackets")`
`167`	`166`	`}`
`@@ -183,8 +182,12 @@ func (p *processor) deliverPackets() {`
`183`	`182`	`if testpanic {`
`184`	`183`	`panic("ns: tun: forwarder: deliverPackets rand10pc")`
`185`	`184`	`}`
`186`		`- if testfatal {`
	`185`	`+ if settings.FatalAtRandom.Load() {`
`187`	`186`	`core.RuntimeWtf("ns: tun: forwarder: test fatal")`
	`187`	`+ if rand10pc() {`
	`188`	`+ var mu sync.Mutex`
	`189`	`+ mu.Unlock() // ka-boom`
	`190`	`+ }`
`188`	`191`	`}`
`189`	`192`	`}`
`190`	`193`