dialers/retrier: todo comments

ignoramous · ignoramous · commit c0e2d08ce594 · 2025-05-17T22:19:38.000+05:30
diff --git a/intra/dialers/retrier.go b/intra/dialers/retrier.go
@@ -539,6 +539,7 @@ func (r *retrier) Write(b []byte) (int, error) {
 // retries are done; before which reads are delegated to copyOnce.
 func (r *retrier) ReadFrom(reader io.Reader) (bytes int64, err error) {
 	copies := 0
+	// TODO: skip copyOnce if r.multidial set or if strat is SplitNever?
 	for !r.retryCompleted() {
 		b, e := copyOnce(r, reader)
 		copies++
@@ -547,6 +548,7 @@ func (r *retrier) ReadFrom(reader io.Reader) (bytes int64, err error) {
 		if e != nil {
 			return bytes, e
 		}
+		// TODO: return after first copyOnce if strat is RetryNever?
 	}
 
 	c := r.conn // reader thread does not need the mutex

Original file line number	Diff line number	Diff line change
`@@ -539,6 +539,7 @@ func (r *retrier) Write(b []byte) (int, error) {`
`539`	`539`	`// retries are done; before which reads are delegated to copyOnce.`
`540`	`540`	`func (r *retrier) ReadFrom(reader io.Reader) (bytes int64, err error) {`
`541`	`541`	`copies := 0`
	`542`	`+ // TODO: skip copyOnce if r.multidial set or if strat is SplitNever?`
`542`	`543`	`for !r.retryCompleted() {`
`543`	`544`	`b, e := copyOnce(r, reader)`
`544`	`545`	`copies++`
`@@ -547,6 +548,7 @@ func (r *retrier) ReadFrom(reader io.Reader) (bytes int64, err error) {`
`547`	`548`	`if e != nil {`
`548`	`549`	`return bytes, e`
`549`	`550`	`}`
	`551`	`+ // TODO: return after first copyOnce if strat is RetryNever?`
`550`	`552`	`}`
`551`	`553`
`552`	`554`	`c := r.conn // reader thread does not need the mutex`