lint: core/wire icmp header Stringer

Author: ignoramous

intra/core/wire/icmp6.go

@@ -49,7 +49,7 @@ func (t ICMP6Type) String() string {
 	case ICMP6EchoReply:
 		return "EchoReply"
 	default:
-		return "Unknown"
+		return "Unknown " + string(t)
 	}
 }
 

intra/core/wire/parsed.go

@@ -388,10 +388,11 @@ func (q *Parsed) IP6Header() IP6Header {
 }
 
 func (q *Parsed) ICMPHeaderString() string {
-	if q.IPProto == ICMPv4 {
-		return fmt.Sprint("%s", q.ICMP4Header())
-	} else if q.IPProto == ICMPv6 {
-		return fmt.Sprint("%s", q.ICMP6Header())
+	switch q.IPProto {
+	case ICMPv4:
+		return fmt.Sprintf("%v", q.ICMP4Header())
+	case ICMPv6:
+		return fmt.Sprintf("%v", q.ICMP6Header())
 	}
 	return "ICMP{???}"
 }