all: rmv fatal test

Author: ignoramous

intra/netstack/forwarders.go

@@ -44,6 +44,9 @@ import (
 
 const maxForwarders = 8
 
+// disable log.wtf driven exit (it did not work the last time it was tested)
+const testwtf = false
+
 type fiveTuple struct {
 	srcAddr, dstAddr []byte
 	srcPort, dstPort uint16
@@ -164,7 +167,7 @@ func (p *processor) start(wg *sync.WaitGroup) {
 func (p *processor) deliverPackets() {
 	testpanic := !p.testcrash && settings.PanicAtRandom.Load() && rand10pc()
 	if testpanic {
-		defer core.Recover(core.DontExit, "ns.forwarder.deliverPackets")
+		defer core.Recover(core.Exit11, "ns.forwarder.deliverPackets")
 	}
 
 	p.mu.Lock()
@@ -183,7 +186,7 @@ func (p *processor) deliverPackets() {
 
 	if testpanic {
 		panic("ns: tun: forwarder: deliverPackets rand10pc")
-	} else if !p.testcrash && settings.FatalAtRandom.Load() && rand1pc() {
+	} else if testwtf && !p.testcrash && settings.PanicAtRandom.Load() && rand1pc() {
 		p.testcrash = true
 		core.RuntimeWtf("ns: tun: forwarder: test fatal\n")
 		var mu sync.Mutex

intra/settings/config.go

@@ -74,9 +74,5 @@ const IntraUa = "Intra"
 // every once in a while (for testing).
 var PanicAtRandom = atomic.Bool{}
 
-// FatalAtRandom is a global flag to fatally crash the network engine
-// every once in a while (for testing).
-var FatalAtRandom = atomic.Bool{}
-
 // OwnTunFd is a global flag to indicate that the TUN fd is fully owned by netstack.
 var OwnTunFd = atomic.Bool{}

intra/tun2socks.go

@@ -254,13 +254,6 @@ func PanicAtRandom(y bool) {
 	log.I("tun: panic at random? %t", y)
 }
 
-// FatalAtRandom instructs portions under test to fatally crash the network engine.
-// For testing only.
-func FatalAtRandom(y bool) {
-	settings.FatalAtRandom.Store(y)
-	log.I("tun: fatal at random? %t", y)
-}
-
 func pipeCrashOutput(bdg Bridge) (ok bool) {
 	r, w, err := os.Pipe()
 	if err != nil {

intra/tunnel.go

@@ -490,7 +490,6 @@ func (t *rtunnel) stat() (*x.NetStat, error) {
 	out.RDNSIn.PortForward = settings.PortForward.Load()
 	out.RDNSIn.Transparency = settings.EndpointIndependentFiltering.Load()
 	out.RDNSIn.PanicTest = settings.PanicAtRandom.Load()
-	out.RDNSIn.FatalTest = settings.FatalAtRandom.Load()
 	out.RDNSIn.SetUserAgent = settings.SetUserAgent.Load()
 	out.RDNSIn.SystemDNSForUndelegated = settings.SystemDNSForUndelegatedDomains.Load()
 	out.RDNSIn.DefaultDNSAsFallback = settings.DefaultDNSAsFallback.Load()