lint: netstack/icmpecho.go

Author: ignoramous

intra/core/wire/parsed.go

@@ -401,9 +401,9 @@ func (q *Parsed) IP6Header() IP6Header {
 func (q *Parsed) ICMPHeaderString() string {
 	switch q.IPProto {
 	case ICMPv4:
-		return q.ICMP4Header().String()
+		return q.ICMP4Header().Stringer()
 	case ICMPv6:
-		return q.ICMP6Header().String()
+		return q.ICMP6Header().Stringer()
 	}
 	return "ICMP" + string(q.IPVersion) + "{???}"
 }
@@ -416,11 +416,11 @@ func (q *Parsed) ICMP4Header() ICMP4Header {
 	}
 }
 
-func (h ICMP4Header) String() string {
+func (h ICMP4Header) Stringer() string {
 	return fmt.Sprintf("%v", h)
 }
 
-func (h ICMP6Header) String() string {
+func (h ICMP6Header) Stringer() string {
 	return fmt.Sprintf("%v", h)
 }
 

intra/netstack/icmpecho.go

@@ -183,7 +183,7 @@ func (r *icmpResponder) echoReply(pkt *wire.Parsed, d []byte, ok bool) ([]byte,
 			(&icmpHdr).Type = wire.ICMP4Unreachable
 			(&icmpHdr).Code = wire.ICMP4HostUnreachable
 		}
-		tag := icmpHdr.String()
+		tag := icmpHdr.Stringer()
 		return wire.Generate(&icmpHdr, d), header.IPv4ProtocolNumber, tag, nil
 	case 6:
 		icmpHdr := pkt.ICMP6Header()
@@ -192,7 +192,7 @@ func (r *icmpResponder) echoReply(pkt *wire.Parsed, d []byte, ok bool) ([]byte,
 			(&icmpHdr).Type = wire.ICMP6Unreachable
 			(&icmpHdr).Code = wire.ICMP6NoRoute
 		}
-		tag := icmpHdr.String()
+		tag := icmpHdr.Stringer()
 		// github.com/tailscale/tailscale/blob/7de1b0b33082cc/wgengine/userspace.go#L577
 		return wire.Generate(&icmpHdr, d), header.IPv6ProtocolNumber, tag, nil
 	default: