Skip to content

intra/core: fix DisableKeepAlive#152

Merged
ignoramous merged 1 commit intocelzero:n2from
Lanius-collaris:work1
May 13, 2025
Merged

intra/core: fix DisableKeepAlive#152
ignoramous merged 1 commit intocelzero:n2from
Lanius-collaris:work1

Conversation

@Lanius-collaris
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread intra/core/sockopt.go
return false
}
err = raw.Control(func(fd uintptr) {
syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_KEEPALIVE, 0)

Check warning

Code scanning / gosec

Errors unhandled Warning

Errors unhandled
@ignoramous
Copy link
Copy Markdown
Contributor

Thanks. Does this current code differ from what Golang's API does on *nix?

@ignoramous ignoramous merged commit dffca1f into celzero:n2 May 13, 2025
4 of 6 checks passed
@Lanius-collaris
Copy link
Copy Markdown
Contributor Author

Does this current code differ from what Golang's API does on *nix?

On Plan 9, it differs from what Golang's std does.
https://cs.opensource.google/go/go/+/refs/tags/go1.24.3:src/net/tcpsock.go;l=234
https://cs.opensource.google/go/go/+/refs/tags/go1.24.3:src/net/sockopt_posix.go;l=87
https://cs.opensource.google/go/go/+/refs/tags/go1.24.3:src/net/sockopt_plan9.go;l=9

@Lanius-collaris Lanius-collaris deleted the work1 branch May 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants