Skip to content

Fix triangle.c pointer cast for x64 systems#6

Closed
ppizarror wants to merge 1 commit into
cemcen:masterfrom
SmartBuildingDesign:fix-triangle
Closed

Fix triangle.c pointer cast for x64 systems#6
ppizarror wants to merge 1 commit into
cemcen:masterfrom
SmartBuildingDesign:fix-triangle

Conversation

@ppizarror
Copy link
Copy Markdown

@ppizarror ppizarror commented Nov 10, 2022

This PR fixes triangle.c library, which assumes that sizeof(long) equals 8, and uses unsigned long as the type of pointer. But sizeof(long) equals 4 when compiling in VS/mingw/x64, so unsigned long cannot be the type of the pointer in x64.

Now, I successfully compiled the project, and ran the tests!

Also, PR #4 should be merged as well.

Greetings,

Pablo

@ppizarror ppizarror changed the title Fix pointer cast for x64 systems Fix triangle.c pointer cast for x64 systems Nov 10, 2022
@ppizarror
Copy link
Copy Markdown
Author

ppizarror commented Nov 11, 2022

For OSX compatibility, on line 649 of triangle.c the following should be added:

[LINE 649]/* Random number seed is not constant, but I've made it global anyway.       */

/* Fix for MacOS*/
#ifndef __int64
#ifdef __APPLE__
typedef long long __int64;
#else
#error Must define __int64 for your platform
#endif
#endif

__int64 randomseed;                     /* Current random number seed. */

@ppizarror ppizarror closed this Oct 30, 2024
@ppizarror ppizarror deleted the fix-triangle branch October 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error occur in Test Project

1 participant