making wii motes less crashy#1853
Open
Squall-Leonhart wants to merge 1 commit into
Open
Conversation
probe devices outside the exclusive lock to avoid blocking reader/writer threads during I/O Replace newly opened handles with existing ones for already-active devices to avoid closing and reopening handles every poll cycle improve device connect/disconnect safety. remove early is_connected return that prevented cemu from setting the LED on re-associated wiimotes.
Author
|
review please @capitalistspz |
Author
|
so far i've been able to bind the same remote to every tab, remove it, and bind it again without a crash, usually it'd happen by the 4th or 5th. |
| std::vector<WiimoteDevicePtr> reachableDevices; | ||
| for (auto& device : devices) | ||
| { | ||
| const auto writeable = device->write_data({kStatusRequest, 0x00}); |
Contributor
There was a problem hiding this comment.
HidapiWiimote::write_data calls hid_write, which isn't thread safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probe devices outside the exclusive lock to avoid blocking reader/writer threads during I/O
Replace newly opened handles with existing ones for already-active devices to avoid closing and reopening handles every poll cycle (handle shenigans can be racy)
improve device connect/disconnect safety.
remove early is_connected return that prevented cemu from setting the LED on re-associated wiimotes on hot-swap/reconnect and on start if a mote is already associated and attached.