Skip to content

enh(os::wndows::wsman::plugin) Improve gssnegotiate authentication support #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omercier merged 2 commits into from
Jun 26, 2026
Merged

enh(os::wndows::wsman::plugin) Improve gssnegotiate authentication support #6257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c65a9
Improve error message for gssnegotiate authentication failure
scresto31 Jun 19, 2026
131f4c9
Update after review
scresto31 Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 34 additions & 25 deletions src/centreon/plugins/wsman.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ use warnings;
use openwsman;
use MIME::Base64;

use constant WS_LASTERR_LOGIN_DENIED => 26;

my %auth_method_map = (
noauth => $openwsman::NO_AUTH_STR,
basic => $openwsman::BASIC_AUTH_STR,
Expand Down Expand Up @@ -61,17 +63,18 @@ sub new {

$options{options}->add_options(arguments => {
'hostname|host:s' => { name => 'host' },
'wsman-port:s' => { name => 'wsman_port', default => 5985 },
'wsman-port:s' => { name => 'wsman_port', default => 5985, type => 'port', not_empty => 1 },
'wsman-path:s' => { name => 'wsman_path', default => '/wsman' },
'wsman-scheme:s' => { name => 'wsman_scheme', default => 'http' },
'wsman-username:s' => { name => 'wsman_username' },
'wsman-password:s' => { name => 'wsman_password' },
'wsman-timeout:s' => { name => 'wsman_timeout', default => 30 },
'wsman-scheme:s' => { name => 'wsman_scheme', default => 'http', type => 'protocol_http', not_empty => 1 },
'wsman-username:s' => { name => 'wsman_username', default => '' },
'wsman-password:s' => { name => 'wsman_password', default => '' },
'wsman-timeout:s' => { name => 'wsman_timeout', default => 30, type => 'numeric', not_empty => 1 },
'wsman-proxy-url:s' => { name => 'wsman_proxy_url' },
'wsman-proxy-username:s' => { name => 'wsman_proxy_username' },
'wsman-proxy-password:s' => { name => 'wsman_proxy_password' },
'wsman-debug:s' => { name => 'wsman_debug' },
'wsman-auth-method:s' => { name => 'wsman_auth_method', default => 'basic' },
'wsman-auth-method:s' => { name => 'wsman_auth_method', default => 'basic', not_empty => 1,
is_in => [ 'noauth', 'basic', 'digest', 'pass', 'ntlm', 'gssnegotiate' ] },
'wsman-errors-exit:s' => { name => 'wsman_errors_exit', default => 'unknown' }
});
$options{options}->add_help(package => __PACKAGE__, sections => 'WSMAN OPTIONS');
Expand Down Expand Up @@ -472,22 +475,10 @@ sub check_options {
}
$self->{wsman_params}->{host} = $options{option_results}->{host};

if (!defined($options{option_results}->{wsman_scheme}) || $options{option_results}->{wsman_scheme} !~ /^(http|https)$/) {
$self->{output}->add_option_msg(short_msg => "Wrong scheme parameter. Must be 'http' or 'https'.");
$self->{output}->option_exit();
}
$self->{wsman_params}->{wsman_scheme} = $options{option_results}->{wsman_scheme};

if (!defined($options{option_results}->{wsman_auth_method}) || !defined($auth_method_map{$options{option_results}->{wsman_auth_method}})) {
$self->{output}->add_option_msg(short_msg => "Wrong wsman auth method parameter. Must be 'basic', 'noauth', 'digest', 'pass', 'ntlm' or 'gssnegotiate'.");
$self->{output}->option_exit();
}

$self->{wsman_params}->{wsman_auth_method} = $options{option_results}->{wsman_auth_method};

if (!defined($options{option_results}->{wsman_port}) || $options{option_results}->{wsman_port} !~ /^([0-9]+)$/) {
$self->{output}->add_option_msg(short_msg => "Wrong wsman port parameter. Must be an integer.");
$self->{output}->option_exit();
}
$self->{wsman_params}->{wsman_port} = $options{option_results}->{wsman_port};

$self->{wsman_params}->{wsman_path} = $options{option_results}->{wsman_path};
Expand All @@ -503,17 +494,35 @@ sub check_options {
sub handle_dialog_fault {
my ($self, %options) = @_;
my $result = $options{result};
my $msg = $options{msg};
my $prefix = $options{msg} // 'Error: ';

unless($result && $result->is_fault eq 0) {
Comment thread
omercier marked this conversation as resolved.
my $fault_string = $self->{client}->fault_string();
my $msg = 'Could not enumerate instances: ' . ((defined($fault_string)) ? $fault_string : 'use debug option to have details');
my $error_msg;
if ($self->{wsman_params}->{wsman_auth_method} eq 'gssnegotiate' && $self->{client}->last_error() == WS_LASTERR_LOGIN_DENIED) {
$error_msg = qq~Failed to authenticate using 'gssnegotiate'.
Please verify that:
- a valid Kerberos ticket is available on the machine running the plugin (check with the 'klist' command),
- the target host name is correct,
- the Kerberos configuration is valid.
Use the debug option for more details.
~;
} else {
my $fault_string = $self->{client}->fault_string();
$error_msg = $prefix . ((defined($fault_string)) ? $fault_string : 'use the debug option for more details');
# Try to display XML fault response in debug mode
if (defined($result) && defined($self->{wsman_params}->{wsman_debug})) {
my $fault_detail = eval { $result->root()->string() };
if (defined($fault_detail) && $fault_detail ne '') {
$error_msg .= "\nFault details:\n" . $fault_detail;
}
}
}

if ($options{dont_quit} == 1) {
$self->set_error(error_status => -1, error_msg => $msg);
$self->set_error(error_status => -1, error_msg => $error_msg);
return 1;
}
$self->{output}->add_option_msg(short_msg => $msg);
$self->{output}->option_exit(exit_litteral => $self->{wsman_errors_exit});
$self->{output}->option_exit(exit_litteral => $self->{wsman_errors_exit}, short_msg => $error_msg);
}

return 0;
Expand Down
Loading