ceph-dev-pipeline/build/Jenkinsfile: Skip debug containers#2525
Closed
Matan-B wants to merge 1 commit into
Closed
Conversation
Matan-B
requested review from
athanatos,
djgalloway,
dmick and
phlogistonjohn
dmick
reviewed
Jan 14, 2026
| DOCKER_HUB_CREDS = credentials('dgalloway-docker-hub') | ||
| } | ||
| when { | ||
| expression { return build_matrix["${DIST}_${ARCH}"] == true } |
Member
There was a problem hiding this comment.
This is the "builder container" stage, which builds a container for the build. I think it needs to stay.
Contributor
Author
There was a problem hiding this comment.
Can you please help locating which stage needs to be adjusted to skip the debug containers in quay?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Updated accordingly. Thanks @djgalloway.
Perhaps we should, instead of skipping, build an additional container with a different tag so the two won't conflict?
djgalloway
reviewed
Jan 20, 2026
Matan-B
force-pushed
the
wip-matanb-skip-container
branch
from
de4769d to
356126b
Compare
djgalloway
reviewed
Jan 21, 2026
ceph#2497 introduced a debug flavor. This seems to cause conflicts with the image being pushed to quay as one of the flavors might override the other. One possible solution to this would be to name the debug images differently. However, since the current behavior might cause unexpected testing results. Skip building containers for debug builds at all. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B
force-pushed
the
wip-matanb-skip-container
branch
from
356126b to
a997c92
Compare
djgalloway
reviewed
Jan 21, 2026
| when { | ||
| expression { env.CI_CONTAINER == 'true' && container_distros.contains(env.DIST) } | ||
| // Do not build a container for debug builds | ||
| expression { env.CI_CONTAINER == 'true' && container_distros.contains(env.DIST) && env.FLAVOR != 'debug'} |
Contributor
There was a problem hiding this comment.
Nit: Please add a space before the closing bracket
Contributor
Author
|
I think a dedicated tag might be a better solution: ceph/ceph#67041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2497 introduced a debug flavor. This seems to cause conflicts with the image being pushed to quay as one of the flavors might override the other.
One possible solution to this would be to name the debug images differently. However, since the current behavior might cause unexpected testing results. Skip building containers for debug builds at all.