RFE: Helm: allow disable logging and rotation

[sshambar]

Describe the feature you'd like to have

Currently, there's no easy way to disable disk logging in the ceph-csi-drivers chart.

Who is the end user and what is the use case where this feature will be valuable?

Anyone using the chart in an umbrella chart.

Supporting the following would be nice:

operatorConfig:
  driverSpecDefaults:
    log:
       rotation:
         enabled: false

drivers:
  {driver-type}:
     log:
        rotation:
          enabled: false

How will we know we have a good solution? (acceptance criteria)

Allow setting enabled: false from a parent chart.

Additional context

Currently, disabling file logging in a parent chart requires setting:

drivers:
  {driver-type}:
    log:
      rotation: nil

But due to a helm bug (issue number 31118), doing so generates a warning...

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[sshambar]

No interest in this? If not, I'll abandon it :)

[Madhu-1]

@sshambar sounds good to have a workaround. can you please point to the helm issue for this one

[sshambar]

@Madhu-1 - Here's a direct link helm issue#31118

[Madhu-1]

@sshambar feel free to open a PR to fix it. Thank you

[Madhu-1]

@sshambar are you working on this one, planning to take this in for next release

[sshambar]

I could test it, but I currently don't have the bandwidth to work on it -- feel free to take it :)

[Madhu-1]

Thank you @sshambar for your response, @rewantsoni is this something you can work on?

[rewantsoni]

@Madhu-1 Yes, I will take a look today

[rewantsoni]

/assign @rewantsoni

[github-actions]

Thanks for taking this issue! Let us know if you have any questions!