e2e: delete NFS StorageClass in case it already exists

Signed-off-by: Niels de Vos <ndevos@ibm.com>

Author: nixpanic

e2e/nfs.go

@@ -218,7 +218,12 @@ func createNFSStorageClass(
 		if err != nil {
 			framework.Logf("error creating StorageClass %q: %v", sc.Name, err)
 			if apierrs.IsAlreadyExists(err) {
-				return true, nil
+				err = deleteResource(nfsExamplePath + "storageclass.yaml")
+				if err != nil {
+					logAndFail("failed to delete NFS storageclass: %v", err)
+				}
+
+				return false, nil
 			}
 			if isRetryableAPIError(err) {
 				return false, nil
@@ -504,11 +509,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to verify mount options: %v", err)
 			}
-
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 		})
 
 		It("verify RWOP volume support", func() {
@@ -550,10 +550,6 @@ var _ = Describe("nfs", func() {
 				logAndFail("failed to validate RWOP pod creation: %v", err)
 			}
 			validateSubvolumeCount(f, 0, fileSystemName, defaultSubvolumegroup)
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 		})
 
 		It("create a storageclass with pool and a PVC then bind it to an app", func() {
@@ -565,10 +561,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to validate NFS pvc and application binding: %v", err)
 			}
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 		})
 
 		It("create a storageclass with relocated server and a PVC then bind it to an app", func() {
@@ -615,10 +607,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to delete PVC or application: %v", err)
 			}
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 			err = deleteNFSVolumeAttributesClass(f.ClientSet, f)
 			if err != nil {
 				logAndFail("failed to delete NFS voluemattributesclass: %v", err)
@@ -636,10 +624,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to validate NFS pvc and application binding: %v", err)
 			}
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 		})
 
 		It("create a storageclass with a restricted set of clients allowed to mount it", func() {
@@ -668,10 +652,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to delete PVC: %v", err)
 			}
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 		})
 
 		It("create a PVC and bind it to an app", func() {
@@ -1336,10 +1316,6 @@ var _ = Describe("nfs", func() {
 			if err != nil {
 				logAndFail("failed to delete PVC or application: %v", err)
 			}
-			err = deleteResource(nfsExamplePath + "storageclass.yaml")
-			if err != nil {
-				logAndFail("failed to delete NFS storageclass: %v", err)
-			}
 			err = deleteNFSVolumeAttributesClass(f.ClientSet, f)
 			if err != nil {
 				logAndFail("failed to delete NFS volumeattributesclass: %v", err)