Skip to content

helm: Support VolumeSnapshotClass and VolumeGroupSnapshotClass#5240

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
alvistack:devel
Jun 26, 2025
Merged

helm: Support VolumeSnapshotClass and VolumeGroupSnapshotClass#5240
mergify[bot] merged 1 commit into
ceph:develfrom
alvistack:devel

Conversation

@hswong3i
Copy link
Copy Markdown
Contributor

@hswong3i hswong3i commented Mar 27, 2025 •
edited
Loading

Describe what this PR does

This PR add support for creating VolumeSnapshotClass and VolumeGroupSnapshotClass with helm charts. Both default with create: false as StorageClass support.

Moreover, it handle the chart release with branch gh-pages, by integrate with https://github.com/helm/chart-releaser-action.

The sample helm repo could find from https://alvistack.github.io/ceph-ceph-csi/index.yaml, by:

helm repo add ceph-csi https://alvistack.github.io/ceph-ceph-csi
helm repo update
helm search repo ceph-csi

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify Bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Mar 27, 2025
@hswong3i hswong3i force-pushed the devel branch 4 times, most recently from 2519f3a to 83e6c07 Compare March 27, 2025 04:55
@nixpanic
Copy link
Copy Markdown
Member

nixpanic commented Mar 27, 2025

Hi @hswong3i, thanks for the PR!

Could you remove the publishing of the charts from your commit? There is a job already, and it pushes the charts to the https://github.com/ceph/csi-charts repository.

@hswong3i
Copy link
Copy Markdown
Contributor Author

hswong3i commented Mar 31, 2025

Hi @hswong3i, thanks for the PR!

Could you remove the publishing of the charts from your commit? There is a job already, and it pushes the charts to the https://github.com/ceph/csi-charts repository.

@nixpanic dummy https://github.com/helm/chart-releaser-action integration removed, also update charts/*/README.md accordingly with pandoc -f gfm -t gfm --wrap preserve.

@nixpanic
Copy link
Copy Markdown
Member

nixpanic commented Apr 1, 2025

Thanks for the update @hswong3i! I've glanced over it just now, and this looks better than the previous version. It needs a more careful look to check the parameters/values before I feel confident enough to approve it.

@nixpanic nixpanic requested review from a team and yati1998 April 1, 2025 07:11
iPraveenParihar
iPraveenParihar previously requested changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the formatting changes from this PR?

Comment thread charts/ceph-csi-cephfs/README.md Outdated
Comment thread charts/ceph-csi-cephfs/templates/groupsnapshotclass.yaml Outdated
Comment thread charts/ceph-csi-cephfs/README.md Outdated
Comment thread charts/ceph-csi-rbd/README.md Outdated
Comment thread charts/ceph-csi-rbd/README.md Outdated
Comment thread charts/ceph-csi-rbd/README.md Outdated
Comment thread charts/ceph-csi-rbd/values.yaml Outdated
@hswong3i
Copy link
Copy Markdown
Contributor Author

hswong3i commented Apr 4, 2025

Can you please revert the formatting changes from this PR?

Because the table contents are too complicated for manual formatting, so I am using 'pandoc -f gfm -t gfm --wrap preserve' for format linting.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 10, 2025

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

Madhu-1
Madhu-1 reviewed Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do adress the same comments for RBD as well.

Comment thread charts/ceph-csi-cephfs/templates/groupsnapshotclass.yaml Outdated
Comment thread charts/ceph-csi-cephfs/README.md Outdated
Comment thread charts/ceph-csi-cephfs/templates/groupsnapshotclass.yaml
Comment thread charts/ceph-csi-cephfs/values.yaml
Comment thread charts/ceph-csi-cephfs/values.yaml
Comment thread charts/ceph-csi-cephfs/values.yaml Outdated
Madhu-1
Madhu-1 reviewed Apr 10, 2025
View reviewed changes
Comment thread charts/ceph-csi-cephfs/values.yaml Outdated
Madhu-1
Madhu-1 reviewed Apr 10, 2025
View reviewed changes
Comment thread charts/ceph-csi-cephfs/values.yaml Outdated
@hswong3i hswong3i force-pushed the devel branch 5 times, most recently from 14491cc to dd3139d Compare April 10, 2025 11:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 1, 2025
Madhu-1
Madhu-1 previously approved these changes Jun 11, 2025
View reviewed changes
@Madhu-1 Madhu-1 requested a review from iPraveenParihar June 11, 2025 12:58
@Madhu-1 Madhu-1 removed the stale label Jun 11, 2025
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 26, 2025
black-dragon74
black-dragon74 reviewed Jun 26, 2025
View reviewed changes
Comment thread charts/ceph-csi-rbd/values.yaml Outdated
black-dragon74
black-dragon74 requested changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@black-dragon74 black-dragon74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this small nit..

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #5240 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@hswong3i
helm: Support VolumeSnapshotClass and VolumeGroupSnapshotClass
0c55146 
This PR add support for creating VolumeSnapshotClass and
VolumeGroupSnapshotClass with helm charts. Both default with
`create: false` as StorageClass support.

Moreover, it handle the chart release with branch `gh-pages`, by
integrate with <https://github.com/helm/chart-releaser-action>.

The sample helm repo could find from
<https://alvistack.github.io/ceph-ceph-csi/index.yaml>, by:

    helm repo add ceph-csi https://alvistack.github.io/ceph-ceph-csi
    helm repo update
    helm search repo ceph-csi

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@mergify mergify Bot dismissed stale reviews from Madhu-1 and Rakshith-R June 26, 2025 11:38

Pull request has been modified.

@Madhu-1
Copy link
Copy Markdown
Collaborator

Madhu-1 commented Jun 26, 2025

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 26, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 1a01311

@mergify mergify Bot added the ok-to-test Label to trigger E2E tests label Jun 26, 2025
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented Jun 26, 2025

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 26, 2025
@mergify mergify Bot merged commit 1a01311 into ceph:devel Jun 26, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@black-dragon74 black-dragon74 black-dragon74 approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@iPraveenParihar iPraveenParihar Awaiting requested review from iPraveenParihar

@yati1998 yati1998 Awaiting requested review from yati1998

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

No one assigned

Labels

component/deployment Helm chart, kubernetes templates and configuration Issues/PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hswong3i @nixpanic @Madhu-1 @ceph-csi-bot @black-dragon74 @yati1998 @iPraveenParihar @Rakshith-R