Skip to content

rbd: add debug logging to ProcessMetadata for CBT diagnostics #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaovilai wants to merge 1 commit into
base: devel
Choose a base branch
from
+7 −0
Open

rbd: add debug logging to ProcessMetadata for CBT diagnostics #6203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/rbd/snap_diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ func (rbdSnap *rbdSnapshot) ProcessMetadata(
return fmt.Errorf("failed to get snapshot ID of %q: %w", rbdSnap, err)
}

log.DebugLog(ctx, "ProcessMetadata: snapshot=%q, snapID=%d, VolSize=%d", rbdSnap, snapID, rbdSnap.VolSize)

err = image.SetSnapByID(snapID)
if err != nil {
return fmt.Errorf("failed to set snapshot %q by ID %d: %w",
Expand Down Expand Up @@ -107,12 +109,17 @@ func (rbdSnap *rbdSnapshot) ProcessMetadata(
diffIterateByIDConfig.FromSnapID = fromSnapID
}

log.DebugLog(ctx, "ProcessMetadata: DiffIterateByID config: Offset=%d, Length=%d, FromSnapID=%d",
diffIterateByIDConfig.Offset, diffIterateByIDConfig.Length, diffIterateByIDConfig.FromSnapID)

Comment thread
kaovilai marked this conversation as resolved.
diffIterateErr := image.DiffIterateByID(diffIterateByIDConfig)
err = handleDiffIterateError(diffIterateErr)
if err != nil {
return fmt.Errorf("failed to get diff: %w", err)
}

log.DebugLog(ctx, "ProcessMetadata: DiffIterateByID completed successfully")

if len(changedBlocks) != 0 {
// Send any remaining changed blocks after the loop.
err = sendResponse(changedBlocks)
Expand Down
Loading