api: add SecurityContextConstraints to nvmeof ServiceAccounts#6249
Merged
Conversation
nixpanic
added
ci/skip/e2e
Rakshith-R
approved these changes
Apr 23, 2026
Madhu-1
approved these changes
Apr 28, 2026
Contributor
|
Deprecation notice: This pull request comes from a fork and was queued with |
Contributor
Merge Queue Status
This pull request spent 5 minutes 17 seconds in the queue, including 4 minutes 52 seconds running CI. Required conditions to merge
|
The NVMe-oF ServiceAccounts need an SCC so that they can be used on OpenShift. Signed-off-by: Niels de Vos <ndevos@ibm.com>
The RBAC was only added to the file under the deploy/ directory. Running
make containerized-build TARGET=generate-deploy
caused the RBAC to be removed. With the RBAC added to the template in
the api/ directory, the RBAC will be included when generating the
deploy/ directory.
Fixes: aaab765
Signed-off-by: Niels de Vos <ndevos@ibm.com>
ceph-csi-bot
force-pushed
the
nvmeof/api
branch
from
478b57e to
1cddfaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVMe-oF ServiceAccounts need an SCC so that they can be used on OpenShift.
This also showed a minor bug in the
api/directory for NFS:The RBAC for VolumeAttributesClasses was only added to the file under the deploy/ directory. Running
caused the RBAC to be removed. With the RBAC added to the template in
the api/ directory, the RBAC will be included when generating the
deploy/ directory.
Fixes: aaab765
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)