Skip to content

Fix go toolchain versions#6258

Merged
mergify[bot] merged 4 commits into
ceph:develfrom
iPraveenParihar:fix-go-toolchain-versions
May 13, 2026
Merged

Fix go toolchain versions#6258
mergify[bot] merged 4 commits into
ceph:develfrom
iPraveenParihar:fix-go-toolchain-versions

Conversation

@iPraveenParihar
Copy link
Copy Markdown
Contributor

@iPraveenParihar iPraveenParihar commented Apr 29, 2026

Describe what this PR does

The k8s dependency bump set go.mod to go 1.26.0, but build.env
still had Go 1.24.6. Update to Go 1.26.2 (latest 1.26 patch)
so the build toolchain matches the module requirement.

golangci-lint v2.5.0 was built with Go 1.25 and refuses to lint
code targeting Go 1.26.0. Update to v2.9.0, the first version
with Go 1.26 support.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar marked this pull request as ready for review April 30, 2026 07:00
@iPraveenParihar iPraveenParihar mentioned this pull request Apr 30, 2026
Merged
@nixpanic nixpanic requested a review from a team May 1, 2026 08:43
@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 12, 2026

@Mergifyio rebase

@iPraveenParihar @ceph-csi-bot
build: update Go version to 1.26.2
028fe24 
The k8s dependency bump set go.mod to go 1.26.0, but build.env
still had Go 1.24.6. Update to Go 1.26.2 (latest 1.26 patch)
so the build toolchain matches the module requirement.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar @ceph-csi-bot
build: update golangci-lint to v2.9.0
3b07a8b 
golangci-lint v2.5.0 was built with Go 1.25 and refuses to lint
code targeting Go 1.26.0. Update to v2.9.0, the first version
with Go 1.26 support.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar @ceph-csi-bot
util: fix fmt format verbs for int arguments in KMIP KMS
02ee446 
BatchCount and len(BatchItem) are int values, not strings.
Use %d instead of %q to match the argument type, fixing the
govet printf check failure.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@iPraveenParihar @ceph-csi-bot
cleanup: fix modernize and gosec lint warnings
010e4a3 
Apply golangci-lint v2.9.0 modernize auto-fixes:
- interface{} replaced with any
- map copy loops replaced with maps.Copy
- contains loops replaced with slices.Contains
- strings.Index replaced with strings.Cut
- if-min/max replaced with min/max builtins
- aws.String/valueToPointer replaced with new()

Add nolint:gosec for G602 false positives in test files
where slice bounds are guaranteed by test setup.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
@ceph-csi-bot ceph-csi-bot force-pushed the fix-go-toolchain-versions branch from b9487cc to 010e4a3 Compare May 12, 2026 08:09
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 12, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 12, 2026

rebase

✅ Branch has been successfully rebased

@iPraveenParihar iPraveenParihar added the ok-to-test Label to trigger E2E tests label May 13, 2026
@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot
Copy link
Copy Markdown
Collaborator

ceph-csi-bot commented May 13, 2026

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot ceph-csi-bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. and removed ok-to-test Label to trigger E2E tests labels May 13, 2026
@mergify mergify Bot removed the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label May 13, 2026
@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/k8s-e2e-external-storage/1.33

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/mini-e2e-helm/k8s-1.33

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/mini-e2e-helm/k8s-1.34

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/upgrade-tests-cephfs

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/upgrade-tests-rbd

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/upgrade-tests-cephfs

@iPraveenParihar
Copy link
Copy Markdown
Contributor Author

iPraveenParihar commented May 13, 2026

/retest ci/centos/mini-e2e-helm/k8s-1.34

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-05-13 07:28 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-05-13 07:29 UTC · at 010e4a36cccf43a00fa583119ce5bd0412f64a8b · rebase

This pull request spent 12 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit ee2f643 into ceph:devel May 13, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iPraveenParihar @ceph-csi-bot @nixpanic @Madhu-1